1120: Check PowerSupply availability prop for State/Hlth #1281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtmills
approved these changes
May 8, 2025
jeaaustx
approved these changes
May 8, 2025
baemyung
force-pushed
the
1120-Check-PowerSupply-Availability-for-StateAndHealth
branch
2 times, most recently
from
2adf3bf to
04b1619
Compare
baemyung
force-pushed
the
1120-Check-PowerSupply-Availability-for-StateAndHealth
branch
from
04b1619 to
9123781
Compare
|
jenkins run tests please |
|
Currently all BMCWEB PRs are failing because of IBM systems routing issue - which blocks to access The related threads are |
|
Once #1285 is merged, this will be rebased |
This commit makes use of the Available property on the power supply
D-Bus object when determining the power supply state and health in the
PowerSupply response. The power supply monitor code from phosphor-power
will set the property to false if it can determine that the power supply
isn't able to provide power due to certain faults.
If the PS isn't available, then the Health property will be set to
Critical, and the State will be set to UnavailableOffline (assuming it
shouldn't be Absent instead).
This is necessary because on IBM systems the Functional property
determines the fault LED state as well as the health value, and in
certain cases the fault LED needs to stay off even though the PS health
is not OK. A specific example of this is when the PS cord is unplugged:
no fault LED is desired but it is desired for the Redfish output to show
that there is an issue with the PS.
If the Available property isn't present on D-Bus, it acts as if it had a
value of true and behaves the same as it does today.
Tested:
Available = false:
"Health": "Critical",
"State": "UnavailableOffline"
Available = true, Functional = false:
"Health": "Critical",
"State": "Enabled"
PS missing:
"Health": "Critical",
"State": "Absent"
Everything OK:
"Health": "OK",
"State": "Enabled"
No Available property on D-Bus:
"Health": "OK",
"State": "Enabled"
Change-Id: I1a3194bf3a6ca3936954b31439070dcc2f343411
Signed-off-by: Matt Spinler <[email protected]>
Signed-off-by: Myung Bae <[email protected]>
baemyung
force-pushed
the
1120-Check-PowerSupply-Availability-for-StateAndHealth
branch
from
9123781 to
4e29432
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes use of the Available property on the power supply D-Bus object when determining the power supply state and health in the PowerSupply response. The power supply monitor code from phosphor-power will set the property to false if it can determine that the power supply isn't able to provide power due to certain faults.
If the PS isn't available, then the Health property will be set to Critical, and the State will be set to UnavailableOffline (assuming it shouldn't be Absent instead).
This is necessary because on IBM systems the Functional property determines the fault LED state as well as the health value, and in certain cases the fault LED needs to stay off even though the PS health is not OK. A specific example of this is when the PS cord is unplugged: no fault LED is desired but it is desired for the Redfish output to show that there is an issue with the PS.
If the Available property isn't present on D-Bus, it acts as if it had a value of true and behaves the same as it does today.
Tested:
Available = false:
"Health": "Critical",
"State": "UnavailableOffline"
Available = true, Functional = false:
"Health": "Critical",
"State": "Enabled"
PS missing:
"Health": "Critical",
"State": "Absent"
Everything OK:
"Health": "OK",
"State": "Enabled"
No Available property on D-Bus:
"Health": "OK",
"State": "Enabled"
Change-Id: I1a3194bf3a6ca3936954b31439070dcc2f343411