1050: bmcweb update identify association for LED & Item assciation
#573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you also need a openbmc/openbmc change here? |
|
|
Yes, #268 is needed to match between openbmc & bmcweb 's use of '/identifying' (instead of '/identify_led_group'). |
DBus inventory association uses "/identifying" instead of "/identify_led_group". Related upstream: openbmc/phosphor-dbus-interfaces@9eb460c https://gerrit.openbmc.org/c/openbmc/openbmc/+/61068 Signed-off-by: Myung Bae <[email protected]>
baemyung
force-pushed
the
bmcweb-LED-use-identifying-dbus-assosication
branch
from
6080f77 to
a404e56
Compare
lxwinspur
approved these changes
Feb 21, 2023
gtmills
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DBus inventory association uses "/identifying"
instead of "/identify_led_group" according to the latest association interface [1].
[1] openbmc/phosphor-dbus-interfaces@9eb460c
upstream: https://gerrit.openbmc.org/c/openbmc/openbmc/+/61068