Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Temporarily restore Thread/ThreadGroup suspend/resume/stop" (#729) #818

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Revert "Temporarily restore Thread/ThreadGroup suspend/resume/stop" (#729) #818

merged 1 commit into from
Jul 30, 2024

Conversation

LongyuZhang
Copy link
Contributor

@LongyuZhang LongyuZhang commented Jul 25, 2024 •
edited
Loading

@LongyuZhang
Copy link
Contributor Author

The copyright year has been updated. Thanks.

@LongyuZhang
Copy link
Contributor Author

Test Links:
JDK23

  • Reproduce the error with re-build jdk: hyc_grinder_42329
  • Passed on alinux sanity.functional: hyc_grinder_42413
  • Passed on alinux extended.functional: hyc_grinder_42414
  • Passed on xlinux sanity.functional: hyc_grinder_42411
  • Passed on xlinux extended.functional: hyc_grinder_42415
    JDK21 for verify:
  • Passed on xlinux sanity.functional: hyc_grinder_42419
  • Passed on xlinux sanity.functional: hyc_grinder_42418
  • Passed on alinux sanity.functional: hyc_grinder_42416
  • Passed on alinux sanity.functional: hyc_grinder_42417
    @llxia Could you review it? Thanks.

@LongyuZhang LongyuZhang mentioned this pull request Jul 25, 2024
Merged
@LongyuZhang LongyuZhang changed the title Fix thread and threadgroup tests in compile stage Fix thread and threadgroup tests in compile stage for jdknext Jul 25, 2024
@keithc-ca
Copy link
Member

This would be better described as reverting #729.

@keithc-ca keithc-ca self-requested a review July 30, 2024 13:48
@LongyuZhang
Copy link
Contributor Author

This would be better described as reverting #729.

Updated the description. Thanks.

@keithc-ca
Copy link
Member

Please also update the commit message. It should be more like this:

Revert "Temporarily restore Thread/ThreadGroup suspend/resume/stop"

This reverts commit d987abcc506196944c49f1293ba4cd9eb0d3ee81.

@keithc-ca keithc-ca changed the title Fix thread and threadgroup tests in compile stage for jdknext Revert "Temporarily restore Thread/ThreadGroup suspend/resume/stop" (#729) Jul 30, 2024
@keithc-ca keithc-ca mentioned this pull request Jul 30, 2024
Merged
@LongyuZhang
Copy link
Contributor Author

Please also update the commit message. It should be more like this:

Revert "Temporarily restore Thread/ThreadGroup suspend/resume/stop"

This reverts commit d987abcc506196944c49f1293ba4cd9eb0d3ee81.

Updated the commit description as above. Thanks.

@keithc-ca
Copy link
Member

The commit message is not formatted properly. The first line should be a summary, the second line should be blank. The third and subsequent lines, if present, provide more details. See also https://github.com/eclipse/omr/blob/master/CONTRIBUTING.md#commit-guidelines.

This has little to do with fixing tests; the commit message should be as suggested in #818 (comment).

@LongyuZhang
Copy link
Contributor Author

Please also update the commit message. It should be more like this:

Revert "Temporarily restore Thread/ThreadGroup suspend/resume/stop"

This reverts commit d987abcc506196944c49f1293ba4cd9eb0d3ee81.

Updated. Thanks.

@keithc-ca
Copy link
Member

Jenkins test sanity amac jdknext

@keithc-ca
Copy link
Member

The test failures are unrelated to this change.

@keithc-ca keithc-ca merged commit 9d87afb into ibmruntimes:openj9 Jul 30, 2024
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keithc-ca keithc-ca keithc-ca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LongyuZhang @keithc-ca