Fixed the issue where IsPrimaryConstructor's judgment was too conservative, which resulted in the inability to generate correct code in many scenarios.

[sonyps5201314]

some bad test cases:

    class WebPair(string name)
    {
        public string Name { get; } = name;
    }

    class WebPair(string name, string? value, ref readonly object encode)
    {
        public string Name { get; } = name;
    }

    class WebPair(string name, string? value, bool encode = false)
    {
        public string Name { get; } = name;
        public string? Value { get; } = value;
        string? WebValue { get; } = encode ? "111" : value;
        //string? WebValue { get; } = "111" + value;
    }

    class WebPair(string name, string? value, ref readonly object encode)
    {
        public string Name { get; } = name;
        public string? Value { get; } = value;
        string? WebValue { get; } = encode is null ? "111" : value;
        string? WebValue2 { get; } = encode.ToString();
    }

In short:
You cannot assume that the number of constructor parameters and properties is equal, nor can you assume the relationship between the number of instructions and the number of parameters. You cannot assume that xxx in an assignment statement: var property = xxx; is necessarily a value or object. It could be a complex expression like a conditional expression or a concatenation call. You only need to ensure that the value is ultimately assigned to the member field.

[sonyps5201314]

The current judgment is still not rigorous enough. I will refer to the algorithm in dotPeek to improve it tomorrow. The official can take their time to merge it.

[ds5678]

some bad test cases

Shouldn't these be unit tests (rather than listing them in the pull request description)?

[sonyps5201314]

The current judgment is still not rigorous enough. I will refer to the algorithm in dotPeek to improve it tomorrow. The official can take their time to merge it.

Now that I’ve fixed the other issues in the IsPrimaryConstructor check, this PR can be merged safely. As a demonstration, you can correctly decompile the RestSharp library using my latest master branch, but not the official version.

[sonyps5201314]

Shouldn't these be unit tests (rather than listing them in the pull request description)?

I'm not familiar enough with the ILSpy project's code structure yet, so I haven't compiled the unit tests. I've never used unit tests in development before, and I don't have the time to do so right now. This should be a simple task for you and the official team, and you're welcome to add to my work.

Here are some new test cases, which will be supported after applying this pull request. However, dotPeek may still encounter some type parsing errors:

using System.Diagnostics;

namespace TestClassPropertyInit
{

    class WebPair1(string name)
    {
        public string Name { get; } = name;
    }

    class WebPair2(string name, string? value, ref readonly object encode)
    {
        public string Name { get; } = name;
    }

    class WebPair3(string name, string? value, bool encode = false)
    {
        public string Name { get; } = name;
        public string? Value { get; } = value;
        string? WebValue { get; } = encode ? "111" : value;
        //string? WebValue { get; } = "111" + value;
    }

    class WebPair4(string name, string? value, ref readonly object encode)
    {
        public string Name { get; } = name;
        public string? Value { get; } = value;
        string? WebValue { get; } = encode is null ? "111" : value;
        string? WebValue2 { get; } = encode.ToString();
    }

    class WebPair5(string name, string? value)
    {
        public string Name { get; } = name;
    }

    class WebPair6(string name, string? value, ref readonly object encode)
    {
        public string? Value { get; } = name;
        public string Name { get; } = value;
        string? WebValue { get; } = name != null ? "111" : value;
        string? WebValue2 { get; } = value != null ? name : "222";
    }

    public class PersonPrimary_CaptureParams(string name, int age)
    {
        public string GetDetails() => $"{name}, {age}";
    }


    public class PersonPrimary(string name, int age)
    {
        private readonly string _name = name;
    }

    public class PersonRegular1
    {
        private readonly string _name = "name";
        private readonly int _age = 23;

        public PersonRegular1(string name, int age)
        {
            Thread.Sleep(1000);
            _age = name.Length;
        }
    }

    public class PersonRegular2
    {
        private readonly string _name = "name" + Environment.GetEnvironmentVariable("Path");
        private readonly int _age = Environment.GetEnvironmentVariable("Path")?.Length ?? -1;

        public PersonRegular2(string name, int age)
        {
            //Thread.Sleep(1000);
            //_age = name.Length;
        }
    }

    public class Person(string name, int age)
    {
        private readonly string _name = name;
        private readonly int _age = age;

        // 这个构造函数会调用主构造函数
        public Person(string name, int age, string email) : this(name, age)
        {
            // 这里可以有函数体
            if (string.IsNullOrEmpty(email))
                throw new ArgumentException("Email cannot be empty");
            Email = email;
            Console.WriteLine($"Created person: {name}");
        }

        public string Email { get; init; }
    }


    static class Ensure
    {
        public static T NotNull<T>(T? value, string name) => value ?? throw new ArgumentNullException(name);

        public static string NotEmptyString(object? value, string name)
        {
            var s = value as string ?? value?.ToString();
            if (s == null) throw new ArgumentNullException(name);

            return string.IsNullOrWhiteSpace(s) ? throw new ArgumentException("Parameter cannot be an empty string", name) : s;
        }
    }

    /// <summary>
    /// Parameter container for REST requests
    /// </summary>
    [DebuggerDisplay($"{{{nameof(DebuggerDisplay)}()}}")]
    public abstract record Parameter
    {
        /// <summary>
        /// Parameter container for REST requests
        /// </summary>
        protected Parameter(string? name, object? value, bool encode)
        {
            Name = name;
            Value = value;
            Encode = encode;
        }


        /// <summary>
        /// Parameter name
        /// </summary>
        public string? Name { get; }

        /// <summary>
        /// Parameter value
        /// </summary>
        public object? Value { get; }


        /// <summary>
        /// Indicates if the parameter value should be encoded or not.
        /// </summary>
        public bool Encode { get; }

        /// <summary>
        /// Return a human-readable representation of this parameter
        /// </summary>
        /// <returns>String</returns>
        public sealed override string ToString() => Value == null ? $"{Name}" : $"{Name}={ValueString}";

        protected virtual string ValueString => Value?.ToString() ?? "null";

        /// <summary>
        /// Assists with debugging by displaying in the debugger output
        /// </summary>
        /// <returns></returns>
        protected string DebuggerDisplay() => $"{GetType().Name.Replace("Parameter", "")} {ToString()}";
    }

    public record NamedParameter(string name, object? value, bool encode = true) : Parameter(Ensure.NotEmptyString(name, nameof(name)), value, encode)
    {
    }

    public record QueryParameter(string name, object? value, bool encode = true) : NamedParameter(name, value, encode);


    public class DeserializationException(string response, Exception innerException)
    : Exception("Error occured while deserializing the response", innerException)
    {
        public string Response { get; } = response;
    }

    internal class Program
    {
        static void Main(string[] args)
        {
            Console.WriteLine("Hello, World!");
        }
    }
}