-
Notifications
You must be signed in to change notification settings - Fork 118
[GSoC] Updated DC-DC Verilog Generation and Simulations #230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
harshkhandeparkar
wants to merge
31
commits into
idea-fasoc:main
Choose a base branch
from
harshkhandeparkar:dcdc-verilog-mako
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
3b22652
feat: use the new verilog generation module in dcdc-gen
harshkhandeparkar 6a9b124
fix: return stringified powmux_config
harshkhandeparkar fc8fca9
feat: update dcdc-gen verilog to use Mako syntax
harshkhandeparkar 5b89116
feat: gitignore generated verilog in dcdc-gen
harshkhandeparkar 8f7b28d
feat: remove unused code in dcdc_gen.py
harshkhandeparkar 2c18599
feat: added a command to make clean to remove generated verilog in dc…
harshkhandeparkar 721dff6
fix: added missing semicolon in dcdc verilog
harshkhandeparkar 6318148
fix: removed simulations from clean command
harshkhandeparkar 2f87a09
fix: renamed dcdc-gen module_name to prevent collision
harshkhandeparkar f9adecc
fix<dcdc>: run make finish for synth and apr
harshkhandeparkar 12dde5b
fix<dcdc>: copy the correct files from flow/ to work/
harshkhandeparkar 3bcbc7b
feat: uncomment `sky130hd_dcdc` make command
harshkhandeparkar 13db917
feat<dcdc>: added error handling for flow steps
harshkhandeparkar af21bea
fix<dcdc>: added 2_1_floorplan.def as a prerequisite for the def mani…
harshkhandeparkar 276ca01
fix<dcdc>: disabled custom macro placement which was not working
harshkhandeparkar de601d5
fix<dcdc>: disabled the noise injection module
harshkhandeparkar 633203a
fix<dcdc>: commented unused input
harshkhandeparkar 567747b
fix<dcdc>: updated design name for sky130hs
harshkhandeparkar b90b19b
feat<dcdc>: enabled sky130hs commands in makefile
harshkhandeparkar 836b136
feat<dcdc>: enabled sky130hs
harshkhandeparkar 2ac0630
fix: added the correct width values in blocks/
harshkhandeparkar 00df85a
fix: updated more width values
harshkhandeparkar f7e765e
fix: removed typo from auxcell.cdl
harshkhandeparkar 91c291c
feat: added extracted dcdc netlist
harshkhandeparkar 1638bcc
feat: added a dcdc simulation testbench
harshkhandeparkar ceb1527
feat: added make command to run dcdc simulations
harshkhandeparkar 07a978e
feat: gitignored dcdc simulations
harshkhandeparkar ca2b5ed
fix: removed unused code and comments in dcdc_gen.py
harshkhandeparkar b94e660
fix: removed unused imports in dcdc generator
harshkhandeparkar 49ef422
fix<dcdc>: fixed typo in make clean
harshkhandeparkar 6e04b0d
fix: uncommented flow parts in Makefile
harshkhandeparkar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
__pycache__/ | ||
work/ | ||
*.csv | ||
simulations/runs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
openfasoc/generators/dcdc-gen/flow/design/sky130hd/dcdc/config.mk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
openfasoc/generators/dcdc-gen/flow/design/sky130hs/dcdc/config.mk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
dcdc/ |
21 changes: 0 additions & 21 deletions
21
openfasoc/generators/dcdc-gen/flow/design/src/dcdc/DCDC_BUFFER.sv
This file was deleted.
Oops, something went wrong.
73 changes: 0 additions & 73 deletions
73
openfasoc/generators/dcdc-gen/flow/design/src/dcdc/DCDC_NOV_CLKGEN.sv
This file was deleted.
Oops, something went wrong.
32 changes: 0 additions & 32 deletions
32
openfasoc/generators/dcdc-gen/flow/design/src/dcdc/DCDC_POWMUX.v
This file was deleted.
Oops, something went wrong.
83 changes: 0 additions & 83 deletions
83
openfasoc/generators/dcdc-gen/flow/design/src/dcdc/DCDC_SIX_STAGES_CONV.v
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the reason for removing dependencies for macro placement?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neither the macro placement nor the
place_six_stage.py
file were working. I believe the Python file is incomplete, and the macro placement has some outdated code and no longer works with the latest version of OpenROAD. I had removed them to test if the rest of the flow was working, but it was not. Should I revert these changes?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@minghungumich ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andylithia can you review this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you revert the changes and submit an issue about the dependency issue you're seeing? I can try to fix it