Conversation
Matplotlib_common/plot_profs.py
Outdated
| profiles_file = open(file_name, "r") | ||
| my_pos = read_my_var(profiles_file, "position") | ||
| ## my_pos = read_my_var(profiles_file, "position") | ||
| my_pos = read_my_var(profiles_file, "time") |
There was a problem hiding this comment.
When plotting profiles, my_pos is altitude, not time.
If you want to change from position to time in plot_series, please change from position to altitude in plot_profs.
That may require additional changes in matplotlib code.
…into Workshop merge
This reverts commit ed62eef.
drawbicyc/drawbicyc.cpp
Outdated
| ("dir", po::value<std::string>()->required() , "directory containing out_lgrngn") | ||
| ("micro", po::value<std::string>()->required(), "one of: blk_1m, blk_2m, lgrngn") | ||
| ("type", po::value<std::string>()->required(), "one of: dycoms, moist_thermal, rico, Lasher_Trapp")//, base_prflux_vs_clhght") | ||
| ("type", po::value<std::string>()->required(), "one of: dycoms, moist_thermal, rico, Lasher_Trapp, ICMW2020")//, base_prflux_vs_clhght") |
There was a problem hiding this comment.
change ICMW2020 to ICMW2020_cc to distinguish that this is the cumulus congestus case
| } | ||
| // accumulated volume precipitation [m^3] | ||
| double calc_acc_volume_precip(double prec_vol) | ||
| double calc_acc_surf_precip__volume(double prec_vol) |
There was a problem hiding this comment.
why double underscore before volume?
| { | ||
| if(this->micro == "lgrngn") | ||
| return prec_vol / this->DomainVolume; | ||
| return prec_vol / this->DomainSurf * calc_acc_surf_precip(prec_vol); |
There was a problem hiding this comment.
it should be:
return calc_acc_surf_precip(prec_vol) * this->DomainSurf / 1000.
regardless of the microphysics used (lgrngn or blk_1m)
| snap *= plotter.CellVol; | ||
| res_prof(at) = blitz::sum(snap); |
There was a problem hiding this comment.
it would be more efficient to sum all elements first and then multiply the result by cellvol instead of multiplying all elements by the same value and summing afterwards.
Also, currently this only counts cloud droplets. You need to add rain_rw_mom0
2 participants
No description provided.