prs solvers laplacian calc (with err_init): move set_edges before G m…#501
Open
pdziekan wants to merge 1 commit intoigfuw:masterfrom
Open
prs solvers laplacian calc (with err_init): move set_edges before G m…#501pdziekan wants to merge 1 commit intoigfuw:masterfrom
pdziekan wants to merge 1 commit intoigfuw:masterfrom
Conversation
…ultiplication (but also before normalize_vip...) - fixes open bconds with nonzero initial velocity
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the pressure solver's Laplacian calculation that affected open boundary conditions with nonzero initial velocity. The fix reorders operations in the lap function to ensure edge values are set before metric tensor (G) multiplication and velocity normalization, which is critical for correctly handling open boundary conditions.
Changes:
- Moved
set_edgescall before G multiplication andnormalize_vipoperations in the Laplacian calculation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ultiplication (but also before normalize_vip...) - fixes open bconds with nonzero initial velocity