Skip to content

refactor(cosmosgen): generate openapi for external modules#4741

Merged
julienrbrt merged 9 commits into
mainfrom
julien/openapi
Jul 1, 2025
Merged

refactor(cosmosgen): generate openapi for external modules#4741
julienrbrt merged 9 commits into
mainfrom
julien/openapi

Conversation

@julienrbrt

Copy link
Copy Markdown
Member

@clockworkgr

Copy link
Copy Markdown
Collaborator

erm...we seem to be writing json inside a yml file....

not sure whats happened there

@julienrbrt

Copy link
Copy Markdown
Member Author

erm...we seem to be writing json inside a yml file....

not sure whats happened there

the bump to openapi v2... that is true that is confusing 😅

@julienrbrt

julienrbrt commented Jun 26, 2025

Copy link
Copy Markdown
Member Author

https://github.com/grpc-ecosystem/grpc-gateway/blob/main/protoc-gen-openapiv2/main.go#L45

i will update. i didn't even noticed the format change.

@julienrbrt

Copy link
Copy Markdown
Member Author

https://github.com/grpc-ecosystem/grpc-gateway/blob/main/protoc-gen-openapiv2/main.go#L45

i will update. i didn't even noticed the format change.

https://github.com/grpc-ecosystem/grpc-gateway/blob/main/protoc-gen-openapiv2/main.go#L45

i will update. i didn't even noticed the format change.

Looks like there a bug upstream that makes this not work, i'll update to json everywhere (expect the faucet)

@github-actions github-actions Bot added component:docs Documentation additions or improvements. component:templates type:internal labels Jun 26, 2025
@github-actions

github-actions Bot commented Jun 26, 2025

Copy link
Copy Markdown
Contributor

Visit the preview URL for this PR (updated for commit 6830908):

https://igntservices-docs--pr4741-julien-openapi-a8y4d2av.web.app

(expires Mon, 07 Jul 2025 19:28:06 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 95379efd94dd497aaa37c2d0354e6e2cafca5ec5

@julienrbrt
julienrbrt enabled auto-merge (squash) June 30, 2025 15:51
@Pantani

Pantani commented Jul 1, 2025

Copy link
Copy Markdown
Contributor

Should it also generate the Swagger API for the other modules?

Screenshot 2025-07-01 at 02 21 24

@julienrbrt

Copy link
Copy Markdown
Member Author

Should it also generate the Swagger API for the other modules?

Screenshot 2025-07-01 at 02 21 24

we do that too in this PR. What you are having is the cache issue bug that I will fix in the follow up.
In the meantime you cache delete ~/.ignite and ~/.mars, and then re-generate.

@Pantani

Pantani commented Jul 1, 2025

Copy link
Copy Markdown
Contributor

If you scaffold a chain with an empty cache and serve without clearing the cache, the ignite will generate only the chain API:

Cleaning the cache before serve:
Screenshot 2025-07-01 at 05 32 47

Without cleaning the cache:
Screenshot 2025-07-01 at 05 34 41

@Pantani

Pantani commented Jul 1, 2025

Copy link
Copy Markdown
Contributor

but I checked here, this issue is already on the main branch

@julienrbrt

julienrbrt commented Jul 1, 2025

Copy link
Copy Markdown
Member Author

but I checked here, this issue is already on the main branch

Yes, correct, i am working on a fix. @clockworkgr found this bug while using the ts-client.
This happens for more than the openapi generation (so this is why i do not include it here -- plus i haven't entirely fixed it yet 😅)

@julienrbrt
julienrbrt merged commit c1db132 into main Jul 1, 2025
46 of 47 checks passed
@julienrbrt
julienrbrt deleted the julien/openapi branch July 1, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants