Create config.yaml for PtX module#10
Closed
francescolovat wants to merge 2 commits intoiiasa:mainfrom
Closed
Conversation
f3ef685 to
f35ec06
Compare
f35ec06 to
4b3c833
Compare
Codecov Report
@@ Coverage Diff @@
## main #10 +/- ##
============================================
+ Coverage 68.12% 100.00% +31.87%
============================================
Files 75 17 -58
Lines 5066 647 -4419
============================================
- Hits 3451 647 -2804
+ Misses 1615 0 -1615 |
88af0d8 to
dfd4d99
Compare
- DAC techs description is incomplete.
Contributor
|
@khaeru, as discussed in Slack, I’ve reviewed this PR and can confirm that it is no longer relevant for the PtX, CCS, and CDR implementation in the ScenarioMIP workflow. The functions and data proposed here have been superseded by the current CCS and DACCS implementation, which was merged in #419. We can therefore close this PR without merging. |
Member
|
@ywpratama thanks for the confirmation and for the pointer to the current implementation! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far, this PR adds a draft of configuration file for the PtX module in iiasa/message_data#169.
This is done for using
Contextmethods and other utils such asload_package_data()frommessage_ix_models.Depending on time availability:
Migrate full code (excl. data sources) fromPostponed for after publication.message_data.