-
Notifications
You must be signed in to change notification settings - Fork 41
Transport improvements from 2025-W05 #289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #289 +/- ##
========================================
+ Coverage 65.9% 77.3% +11.4%
========================================
Files 215 217 +2
Lines 16572 16804 +232
========================================
+ Hits 10922 13006 +2084
+ Misses 5650 3798 -1852
🚀 New features to boost your workflow:
|
3da90c3
to
bd02b58
Compare
a0b8292
to
9ddfad7
Compare
2d7e972
to
faced45
Compare
faced45
to
c09976b
Compare
- Shift utility function to .util.has_input_commodity(). - Correct filter for gas-using techs to constrain.
- Collect leaf IDs recursively in get_technology_groups()
- Allow common reference to keys containing structure info. - Skip transport tests if using a version of genno without genno.Keys.
Drop older version in .util.genno.
- Use the first-party operator provided by genno ≥1.28.0. - Adjust invocation in .freight.prepare_computer() and .base.smooth.clip_nan().
- Set up full calculation first, then replace/truncate. - Add a test case and expand checks. - Relax expectation that .transport.Config.project(navigate=…) is present.
- Adjust imports per genno 1.25.0. - Provide old implementation via .util.genno for genno < 1.25 (with message_ix/ixmp 3.7.0).
Per genno 1.28.0.
…according to the version policy.
The warning handled no longer appears with pint 0.24.4 and pandas 2.2.3.
c09976b
to
9a38ac2
Compare
@khaeru I rebased the branch and dropped the EDIT: None of the 'TEMPORARY' commits contain anything related to v3.6.0, so that shouldn't make a difference. Could it be that we're now running the pytest workflow file from |
Yes, exactly so.
This is an unfortunate complication that arises from our setup using 'pull_request_trigger' to allow use of secrets on PRs from forks. It is only necessary when modifying the workflow file itself. Maybe there could be some clever way to circumvent the need to do it this way, but I haven't had time to consider that yet. At minimum I guess I should write down somewhere that this process is the one we must use. |
—so, seeing that all jobs except for those upstream-v3.6.0 jobs pass, I'll merge. Thanks for the review and rebase! |
Carried from the previous PR:
Use a smallerNext PR.growth_activity_up
value for (t=ICAm_ptrp, n=R12_RCPA). The technology constraint as of 2020 is effective, but this tech/region grows too rapidly to 2025 and beyond. (per discussion with @r-aneeque 2024-12-04.)Adjust efficiencies of LDV PHEV technologies using duty cycle data.Next PR.growth_activity_up
andact-non_ldv.csv
values are set forF ROAD
technologies with, at least, c=gas inputs. This is to avoid the behaviour (observed by @r-aneeque) that the model quickly switches into these in 2025–2030.ReworkNext PR..transport.Config.constraint
to simplify the setting of these constraints.In addition:
main
.How to review
PR checklist