Export filename and export format types#197
Open
jonokhor wants to merge 2 commits intoilich:masterfrom
medhealth:export-filename-and-export-format-types
Open
Export filename and export format types#197jonokhor wants to merge 2 commits intoilich:masterfrom medhealth:export-filename-and-export-format-types
jonokhor wants to merge 2 commits intoilich:masterfrom
medhealth:export-filename-and-export-format-types
Conversation
|
Thanks for fixing this issue. But I found one issue for specific format types. It will work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #162.
Resolves #144.
This is what we're currently using at my company. With #144, a decision was made to specify the export format types to display rather than the types to hide because it is more useful to us to specify it that way.
Happy to take any feedback.