improve New User password validation #8176
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelchadwick
force-pushed
the
frontend-4303-strength-indicator-new-passwords
branch
from
8f98dd9
to
c16cdc5
Compare
michaelchadwick
force-pushed
the
frontend-4303-strength-indicator-new-passwords
branch
from
b5e4101
to
5290c6c
Compare
michaelchadwick
force-pushed
the
frontend-4303-strength-indicator-new-passwords
branch
from
5290c6c
to
5c79845
Compare
stopfstedt
reviewed
Nov 8, 2024
| {{on "keyup" this.keyboard}} | ||
| data-test-password-input | ||
| /> | ||
| {{#if (this.hasErrorForPassword)}} |
There was a problem hiding this comment.
Suggested change
| {{#if (this.hasErrorForPassword)}} | |
| {{#if this.hasErrorForPassword}} |
There was a problem hiding this comment.
This worked to fix the actual app, but tests still don't show the error message :-/ (notice no red error message for the password field)
There was a problem hiding this comment.
@stopfstedt OK, so the error message appears in the Integration test for PasswordValidator, but when it's used on the NewUser component, it does not. Seems it's being swallowed when trying to move upwards, but not sure how to fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ilios/ilios#4303
Adds a 5-character length validation to new passwords. Potential addition to this PR would be to carry over the password strength logic from
<UserProfileBio>. However, to reduce duplication, maybe it should be refactored to a service?