-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): bump junit.version from 5.7.0 to 5.12.1 #3241
base: master
Are you sure you want to change the base?
Conversation
PR SummaryThis PR updates the Changes
autogenerated by presubmit.ai |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚨 Pull request needs attention.
Review Summary
Commits Considered (1)
- 0d16d7e: build(deps): bump junit.version from 5.7.0 to 5.12.1
Bumps junit.version
from 5.7.0 to 5.12.1.
Updates org.junit.jupiter:junit-jupiter-engine
from 5.7.0 to 5.12.1
Updates org.junit.jupiter:junit-jupiter-params
from 5.11.4 to 5.12.1
Updates org.junit.jupiter:junit-jupiter-migrationsupport
from 5.11.4 to 5.12.1
updated-dependencies:
- dependency-name: org.junit.jupiter:junit-jupiter-engine
dependency-version: 5.12.1
dependency-type: direct:production
update-type: version-update:semver-minor - dependency-name: org.junit.jupiter:junit-jupiter-params
dependency-version: 5.12.1
dependency-type: direct:production
update-type: version-update:semver-minor - dependency-name: org.junit.jupiter:junit-jupiter-migrationsupport
dependency-version: 5.12.1
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] [email protected]
Files Processed (3)
- front-controller/pom.xml (1 hunk)
- pom.xml (1 hunk)
- table-inheritance/pom.xml (1 hunk)
Actionable Comments (1)
-
pom.xml [52-52]
possible bug: "Verify test suite after JUnit upgrade."
Skipped Comments (2)
-
front-controller/pom.xml [50-53]
enhancement: "Add test case for JUnit version upgrade."
-
table-inheritance/pom.xml [41-44]
enhancement: "Add test cases for JUnit upgrade."
pom.xml
Outdated
@@ -49,7 +49,7 @@ | |||
<urm-maven-plugin.version>2.1.1</urm-maven-plugin.version> | |||
<maven-compiler-plugin.version>3.14.0</maven-compiler-plugin.version> | |||
<lombok.version>1.18.36</lombok.version> | |||
<junit.version>5.11.4</junit.version> | |||
<junit.version>5.12.1</junit.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure that all tests are still passing after updating to JUnit 5.12.1. Consider adding a regression test.
Bumps `junit.version` from 5.7.0 to 5.12.1. Updates `org.junit.jupiter:junit-jupiter-engine` from 5.7.0 to 5.12.1 - [Release notes](https://github.com/junit-team/junit5/releases) - [Commits](junit-team/junit5@r5.7.0...r5.12.1) Updates `org.junit.jupiter:junit-jupiter-params` from 5.11.4 to 5.12.1 - [Release notes](https://github.com/junit-team/junit5/releases) - [Commits](junit-team/junit5@r5.11.4...r5.12.1) Updates `org.junit.jupiter:junit-jupiter-migrationsupport` from 5.11.4 to 5.12.1 - [Release notes](https://github.com/junit-team/junit5/releases) - [Commits](junit-team/junit5@r5.11.4...r5.12.1) --- updated-dependencies: - dependency-name: org.junit.jupiter:junit-jupiter-engine dependency-version: 5.12.1 dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: org.junit.jupiter:junit-jupiter-params dependency-version: 5.12.1 dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: org.junit.jupiter:junit-jupiter-migrationsupport dependency-version: 5.12.1 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
0d16d7e
to
d9dda27
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ LGTM!
Review Summary
Commits Considered (1)
- d9dda27: build(deps): bump junit.version from 5.7.0 to 5.12.1
Bumps junit.version
from 5.7.0 to 5.12.1.
Updates org.junit.jupiter:junit-jupiter-engine
from 5.7.0 to 5.12.1
Updates org.junit.jupiter:junit-jupiter-params
from 5.11.4 to 5.12.1
Updates org.junit.jupiter:junit-jupiter-migrationsupport
from 5.11.4 to 5.12.1
updated-dependencies:
- dependency-name: org.junit.jupiter:junit-jupiter-engine
dependency-version: 5.12.1
dependency-type: direct:production
update-type: version-update:semver-minor - dependency-name: org.junit.jupiter:junit-jupiter-params
dependency-version: 5.12.1
dependency-type: direct:production
update-type: version-update:semver-minor - dependency-name: org.junit.jupiter:junit-jupiter-migrationsupport
dependency-version: 5.12.1
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] [email protected]
Files Processed (1)
- pom.xml (1 hunk)
Bumps
junit.version
from 5.7.0 to 5.12.1.Updates
org.junit.jupiter:junit-jupiter-engine
from 5.7.0 to 5.12.1Release notes
Sourced from org.junit.jupiter:junit-jupiter-engine's releases.
... (truncated)
Commits
ba9c9ae
Release 5.12.1e28ad4a
Finalize 5.12.1 release notes1044e2c
Move entry to 5.12.1 release notesbea821d
Fix Javadoc formatting1a1a67d
Set stable module name for the standalone JAR file062d3fa
Remove internal packages from API reports74521ab
IntroduceExtensionContext.getEnclosingTestClasses()
1e135b9
Create initial 5.12.1 release notes from templated540e4f
Link to correct method31d60b7
Split API reports by module and packageUpdates
org.junit.jupiter:junit-jupiter-params
from 5.11.4 to 5.12.1Release notes
Sourced from org.junit.jupiter:junit-jupiter-params's releases.
... (truncated)
Commits
ba9c9ae
Release 5.12.1e28ad4a
Finalize 5.12.1 release notes1044e2c
Move entry to 5.12.1 release notesbea821d
Fix Javadoc formatting1a1a67d
Set stable module name for the standalone JAR file062d3fa
Remove internal packages from API reports74521ab
IntroduceExtensionContext.getEnclosingTestClasses()
1e135b9
Create initial 5.12.1 release notes from templated540e4f
Link to correct method31d60b7
Split API reports by module and packageUpdates
org.junit.jupiter:junit-jupiter-migrationsupport
from 5.11.4 to 5.12.1Release notes
Sourced from org.junit.jupiter:junit-jupiter-migrationsupport's releases.
... (truncated)
Commits
ba9c9ae
Release 5.12.1e28ad4a
Finalize 5.12.1 release notes1044e2c
Move entry to 5.12.1 release notesbea821d
Fix Javadoc formatting1a1a67d
Set stable module name for the standalone JAR file062d3fa
Remove internal packages from API reports74521ab
IntroduceExtensionContext.getEnclosingTestClasses()
1e135b9
Create initial 5.12.1 release notes from templated540e4f
Link to correct method31d60b7
Split API reports by module and packageDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)