Made Tag::from_u16, from_u16_exhaustive and to_u16 const#241
Closed
dbartussek wants to merge 1 commit intoimage-rs:mainfrom
Closed
Made Tag::from_u16, from_u16_exhaustive and to_u16 const#241dbartussek wants to merge 1 commit intoimage-rs:mainfrom
dbartussek wants to merge 1 commit intoimage-rs:mainfrom
Conversation
(cherry picked from commit 5c3c25e)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm using image-tiff to write DNG files, using a lot of currently
Unknowntags as a result.For forward compatibility once some of these tags are defined (#47, #210), I'm using
Tag::from_u16_exhaustive.This patch changes the u16 conversion functions to be const functions so
Tagconstants can be defined from raw numeric ids without having to always define them asUnknown.