- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 172
[3.0] 新的 Redis 组件 #679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Draft
      
      
            NHZEX
  wants to merge
  99
  commits into
  imiphp:3.0
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
NHZEX:3.0-new-redis
  
      
      
   
  
    
  
  
  
 
  
      
    base: 3.0
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
                
     Draft
            
            [3.0] 新的 Redis 组件 #679
Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | 看了下大致上没有问题,需要继续完善: 
 | 
ac445d3    to
    211d577      
    Compare
  
    40a975c    to
    906e6fc      
    Compare
  
    ad06eb1    to
    bbae0da      
    Compare
  
    05f6b63    to
    74bfa68      
    Compare
  
    添加新的 Cache/Redis 测试,支持完整单元测试
Update: 修复测试
# Conflicts: # .github/actions/ci-prepare/action.yml # .github/workflows/ci.yml # .github/workflows/phpcs.yml # .github/workflows/phpstan.yml # .github/workflows/rector.yml # src/Cache/Handler/Redis.php
…edis # Conflicts: # .github/workflows/ci.yml
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
重大更改检查清单:
Lua定义方式:src/Components/queue/src/Driver/RedisQueueDriver.phpRedis注入方式并取消大部分 use 闭包的使用方式(不存在其他IO调用且非长时间允许):src/Cache/Handler/Redis.phpRedis驱动测试方式推广:tests/unit/Component/Tests/Cache/RedisCacheTest.php错误修复检查清单:
Cache前缀选项与setMultiple不兼容问题:src/Cache/Handler/Redis.php,[3.0] 修复Cache前缀选项与setMultiple不兼容问题 #688推进调整清单:
Lua类替代更多直接使用evalEx的方式Redis的组件引入方式都推进为与src/Cache/Handler/Redis.php一致Cache*Test目前的模式(后续考虑推进到更多组件)。