Conversation
Add Model Context Protocol server to access hot list data from 60+ platforms through Claude Desktop, OpenClaw, or OpenCode. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- 添加 pnpm/yarn 锁文件 - 添加 coverage、pm2、cache、tmp 目录 - 添加 .sisyphus、.claude、AGENTS.md Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a Model Context Protocol (MCP) server for the DailyHotApi, enabling integration with tools like Claude Desktop to access hot list data from over 60 platforms. The implementation includes authentication logic, an Axios-based API client with route caching, and two core tools: list_hot_platforms and get_hot_list. Feedback focuses on improving the robustness and maintainability of the codebase, specifically recommending the use of custom error classes for more type-safe error handling, ensuring consistency in documentation placeholders, and addressing fragile relative import paths. Additionally, it is suggested to improve observability when the client silently falls back to cached data during API failures.
| "env": { | ||
| "DAILYHOT_API_URL": "http://localhost:6688", | ||
| "DAILYHOT_API_KEY": "" | ||
| } |
There was a problem hiding this comment.
DAILYHOT_API_KEY 的占位符在命令行参数和客户端集成示例中不一致。建议统一使用 your-api-key 以提高文档清晰度。
| if (!apiKey) { | ||
| const error = new Error("API key is required"); | ||
| (error as any).error = "API key is required"; | ||
| throw error; |
There was a problem hiding this comment.
在 requireApiKey 函数中，通过 (error as any).error = "..." 的方式添加错误信息不够类型安全且不符合 TypeScript 最佳实践。建议定义一个自定义错误类来封装这些错误，以便更好地管理和处理不同类型的错误。
| } catch (error) { | ||
| if (routesCache) { | ||
| return routesCache.data; | ||
| } |
There was a problem hiding this comment.
getAllRoutes 在上游 API 请求失败时，如果存在缓存，会静默返回旧的缓存数据。这可能导致调用方无法及时感知到 API 故障。建议在返回缓存数据时，至少记录一个警告日志，并考虑是否需要向调用方传递 API 失败的信息。
| (error as any).error = `Unknown platform: ${args.platform}`; | ||
| throw error; |
There was a problem hiding this comment.
handleGetList 中处理 Unknown platform 错误的方式与 auth.ts 中的问题类似。为了代码一致性和类型安全，建议采用统一的自定义错误类或更规范的错误处理模式。
mcp/src/types.ts
Outdated
| * Type definitions for DailyHotApi MCP Server | ||
| */ | ||
|
|
||
| import type { ListItem, RouterData } from "../../src/types.d.ts"; |
There was a problem hiding this comment.
mcp/src/types.ts 中对 ../../src/types.d.ts 的相对导入路径较为脆弱。如果 mcp 模块未来可能独立发布或移动，这种路径容易失效。建议考虑将共享类型定义提取到公共包中，或使用更稳定的导入方式。
- 将 src/routes、src/utils、src/config 复制到 mcp - 添加 scraper 层直接调用爬虫逻辑 - 修改 MCP 工具使用内置爬虫 - MCP 现在可独立运行，无需 HTTP 服务 - 保留主工程 HTTP API 服务 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- 修改 src/index.ts，移除 HTTP 服务器代码 - 导出 getHotList 和 listPlatforms 供 MCP 使用 - 更新 package.json，添加 MCP 入口 - 移除 HTTP 相关依赖 现在使用 npx @frankxia/dailyhot-mcp 访问热榜数据 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 participant
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com