Added updated check for docs in Makefile - #291
Conversation
|
@kairoaraujo PTAL !! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #291 +/- ##
==========================================
- Coverage 82.40% 1.64% -80.76%
==========================================
Files 10 120 +110
Lines 358 28856 +28498
==========================================
+ Hits 295 476 +181
- Misses 43 28323 +28280
- Partials 20 57 +37 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
kairoaraujo
left a comment
There was a problem hiding this comment.
Hi @DarikshaAnsari,
Thank you for your PR. 🎉
I think we should run the update_docs and the check_docs.
Note: stat -c is not a standard in all OS. Maybe we could check it using diff? 🤔
Nit: I suggest also having it to the .github/workflows for automatic checks. We can do it in another PR as well.
|
@kairoaraujo I have changed all the require changes you've mentioned also I have added checks in .github/workflow . |
|
@kairoaraujo PTAL !! |
Signed-off-by: Dariksha <img_2021021@iiitm.ac.in>
Signed-off-by: Dariksha <img_2021021@iiitm.ac.in>
Signed-off-by: Dariksha <img_2021021@iiitm.ac.in>
Signed-off-by: Dariksha <img_2021021@iiitm.ac.in>
Signed-off-by: John Kjell <john@testifysec.com>
Fixes #180
Acceptance Criteria Met