Merged
Conversation
…nto add_ubsan_test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add UBSAN (Undefined Behavior Sanitizer) support for restart tests in slow test workflow.
Changes
CMakeLists.txt
Added ENABLE_SANITIZER_UNDEFINED CMake option (existing: ENABLE_SANITIZER_THREAD)
When enabled, compiles with -fsanitize=undefined flag
tools/run_restart_test.py
Added --marker parameter to support filtering tests by pytest markers
Default marker is "not slow" to exclude slow tests (same as before)
pytest.ini
Added ubsan marker definition
python/restart_test/conftest.py
Registered ubsan marker for pytest
.github/workflows/slow_tests.yml
Added debug-ubsan build step with -DENABLE_SANITIZER_UNDEFINED=ON
Added debug_ubsan_restart_test job to run UBSAN tests