Skip to content

fix: Handle panics when metadata references indices beyond array length #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
0xikalgo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Handle panics when metadata references indices beyond array length #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/hypercore/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1273,12 +1273,12 @@ pub async fn spot_markets(
.iter()
.enumerate()
.find(|(index, _)| *index as u32 == item.tokens[0])
.expect("base");
.context("base token index not found")?;
let (_, quote) = spot_tokens
.iter()
.enumerate()
.find(|(index, _)| *index as u32 == item.tokens[1])
.expect("quote");
.context("quote token index not found")?;

markets.push(SpotMarket {
name: item.name,
Expand Down Expand Up @@ -1377,7 +1377,10 @@ pub async fn perp_markets(
.await
.context("meta")?;
let data: PerpTokens = resp.json().await?;
let collateral = &spot.tokens[data.collateral_token];
let collateral = spot
.tokens
.get(data.collateral_token)
.context("collateral token index out of bounds")?;
let collateral = SpotToken::from(collateral.clone());
let dex_index = dex.as_ref().map(|dex| dex.index).unwrap_or_default();

Expand Down