-
Notifications
You must be signed in to change notification settings - Fork 311
feat(oss2): Release notes for OSS 2.7.12 #6070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…indentation, and failing codeblock tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, just the comment I left in slack about TagValueIterator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you making the partial write changes in this PR or another one, @jstirnaman ?
A separate PR. I just started working on it and can finish it for v2 within the hour. We don't need to hold this up unless you want. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Additional fixes in the page:
TODO:
--pid-file
has already been published to https://docs.influxdata.com/influxdb/v2/reference/config-options/#pid-fileCloses https://github.com/influxdata/DAR/issues/500
Describe your proposed changes here.
(if necessary)