add lint scripts for agents-cli, agents-cookbook and test-agents

.changeset/fancy-cups-rest.md

@@ -0,0 +1,5 @@
+---
+"@inkeep/agents-cli": minor
+---
+
+add lint script and fix lint warnings

agents-cli/package.json

@@ -14,6 +14,8 @@
   },
   "scripts": {
     "knip": "knip --directory .. --workspace agents-cli --dependencies",
+    "lint": "biome lint --error-on-warnings",
+    "lint:fix": "biome check --write",
     "build": "tsdown",
     "cli": "node ./dist/index.js",
     "postinstall": "node scripts/ensure-keytar.mjs || true",

agents-cli/scripts/ensure-keytar.mjs

@@ -3,9 +3,9 @@
  * Ensures keytar native module is built for local development.
  * This is needed because pnpm doesn't always trigger native module builds.
  */
-import { execSync } from 'child_process';
-import { createRequire } from 'module';
-import { dirname, join } from 'path';
+import { execSync } from 'node:child_process';
+import { createRequire } from 'node:module';
+import { dirname } from 'node:path';
 
 const require = createRequire(import.meta.url);
 

agents-cli/src/__tests__/utils/ci-environment.test.ts

@@ -60,12 +60,12 @@ describe('CI Environment', () => {
     it('should return X-API-Key header in CI mode', () => {
       const headers = getAuthHeaders({ apiKey: 'test-api-key' }, true);
       expect(headers['X-API-Key']).toBe('test-api-key');
-      expect(headers['Authorization']).toBeUndefined();
+      expect(headers.Authorization).toBeUndefined();
     });
 
     it('should return Authorization Bearer header in interactive mode', () => {
       const headers = getAuthHeaders({ accessToken: 'test-token' }, false);
-      expect(headers['Authorization']).toBe('Bearer test-token');
+      expect(headers.Authorization).toBe('Bearer test-token');
       expect(headers['X-API-Key']).toBeUndefined();
     });
 

agents-cli/src/__tests__/utils/config-batch.test.ts

@@ -1,6 +1,6 @@
 import { existsSync, readdirSync, statSync } from 'node:fs';
-import { join, resolve } from 'node:path';
-import { afterEach, beforeEach, describe, expect, it, type Mock, vi } from 'vitest';
+import { join } from 'node:path';
+import { beforeEach, describe, expect, it, type Mock, vi } from 'vitest';
 import { findAllConfigFiles, findConfigFile, getConfigFileNames } from '../../utils/config';
 
 // Mock fs module

agents-cli/src/__tests__/utils/profiles/profile-manager.test.ts

@@ -237,8 +237,8 @@ describe('ProfileManager', () => {
     it('should return profile by name', () => {
       const profile = profileManager.getProfile('local');
       expect(profile).not.toBeNull();
-      expect(profile!.name).toBe('local');
-      expect(profile!.environment).toBe('development');
+      expect(profile?.name).toBe('local');
+      expect(profile?.environment).toBe('development');
     });
 
     it('should return null for nonexistent profile', () => {
@@ -387,7 +387,7 @@ describe('ProfileManager', () => {
       profileManager.removeProfile('local');
 
       const loaded = profileManager.loadProfiles();
-      expect(loaded.profiles['local']).toBeUndefined();
+      expect(loaded.profiles.local).toBeUndefined();
       expect(Object.keys(loaded.profiles)).toEqual(['cloud']);
     });
 

agents-cli/src/commands/init.ts

@@ -88,7 +88,7 @@ async function cloudInitCommand(options?: InitOptions): Promise<void> {
     // Try to load existing credentials from default cloud profile
     try {
       const existingCreds = await loadCredentials('inkeep-cloud');
-      if (existingCreds && existingCreds.accessToken && existingCreds.organizationId) {
+      if (existingCreds?.accessToken && existingCreds.organizationId) {
         credentials = {
           accessToken: existingCreds.accessToken,
           organizationId: existingCreds.organizationId,
@@ -112,7 +112,7 @@ async function cloudInitCommand(options?: InitOptions): Promise<void> {
 
     // Re-check credentials after login
     const newCreds = await loadCredentials('inkeep-cloud');
-    if (newCreds && newCreds.accessToken && newCreds.organizationId) {
+    if (newCreds?.accessToken && newCreds.organizationId) {
       credentials = {
         accessToken: newCreds.accessToken,
         organizationId: newCreds.organizationId,
@@ -134,7 +134,7 @@ async function cloudInitCommand(options?: InitOptions): Promise<void> {
   try {
     const response = await fetch('https://manage-api.inkeep.com/api/cli/me', {
       headers: {
-        Authorization: `Bearer ${credentials!.accessToken}`,
+        Authorization: `Bearer ${credentials?.accessToken}`,
       },
     });
 
@@ -152,7 +152,7 @@ async function cloudInitCommand(options?: InitOptions): Promise<void> {
     selectedTenantName = data.organization.name;
 
     s.stop(`Organization: ${chalk.cyan(selectedTenantName)}`);
-  } catch (error) {
+  } catch {
     s.stop('Failed to fetch organizations');
     console.error(chalk.red('Network error. Please check your connection.'));
     process.exit(1);
@@ -168,7 +168,7 @@ async function cloudInitCommand(options?: InitOptions): Promise<void> {
       `https://manage-api.inkeep.com/tenants/${selectedTenantId}/projects?limit=100`,
       {
         headers: {
-          Authorization: `Bearer ${credentials!.accessToken}`,
+          Authorization: `Bearer ${credentials?.accessToken}`,
         },
       }
     );
@@ -183,7 +183,7 @@ async function cloudInitCommand(options?: InitOptions): Promise<void> {
     projects = data.data || [];
 
     s.stop(`Found ${projects.length} project(s)`);
-  } catch (error) {
+  } catch {
     s.stop('Failed to fetch projects');
     console.error(chalk.red('Network error. Please check your connection.'));
     process.exit(1);

agents-cli/src/commands/profile.ts

@@ -1,6 +1,6 @@
 import * as p from '@clack/prompts';
 import chalk from 'chalk';
-import { CLOUD_REMOTE, type Profile, ProfileError, ProfileManager } from '../utils/profiles';
+import { type Profile, ProfileError, ProfileManager } from '../utils/profiles';
 
 const profileManager = new ProfileManager();
 

agents-cli/src/commands/pull-v3/__tests__/introspect-generator.test.ts

@@ -1,3 +1,4 @@
+// biome-ignore-all lint/suspicious/noTemplateCurlyInString: allow in test
 /**
  * End-to-end integration tests for introspect generator
  */

agents-cli/src/commands/pull-v3/__tests__/project-validator.test.ts

@@ -189,10 +189,6 @@ describe('Project Validator - Key Listener Leak Prevention', () => {
       // Expected
     }
     await new Promise((resolve) => setTimeout(resolve, 50));
-
-    const firstCallOnceCount = mockStdin.once.mock.calls.length;
-    const firstCallRemoveAllCount = mockStdin.removeAllListeners.mock.calls.length;
-
     // Reset for second call
     mockStdin.removeAllListeners.mockClear();
     mockStdin.once.mockClear();

agents-cli/src/commands/pull-v3/__tests__/test-introspect-cli.ts

@@ -1,4 +1,5 @@
 #!/usr/bin/env node
+// biome-ignore-all lint/suspicious/noTemplateCurlyInString: allow in test
 
 /**
  * Manual CLI test script for introspect functionality

agents-cli/src/commands/pull-v3/component-parser.test.ts

@@ -17,15 +17,15 @@ describe('Component Parser', () => {
 
   beforeEach(() => {
     // Create temporary test directory
-    testDir = join(tmpdir(), 'component-parser-test-' + Date.now());
+    testDir = join(tmpdir(), `component-parser-test-${Date.now()}`);
     mkdirSync(testDir, { recursive: true });
   });
 
   afterEach(() => {
     // Clean up test directory
     try {
       rmSync(testDir, { recursive: true, force: true });
-    } catch (error) {
+    } catch {
       // Ignore cleanup errors
     }
   });

agents-cli/src/commands/pull-v3/component-parser.ts

@@ -8,7 +8,6 @@
 
 import { existsSync, readdirSync, readFileSync, statSync } from 'node:fs';
 import { extname, join, relative } from 'node:path';
-import chalk from 'chalk';
 import { type CallExpression, Node, type ObjectLiteralExpression, Project } from 'ts-morph';
 import { ComponentRegistry, type ComponentType } from './utils/component-registry';
 
@@ -485,9 +484,6 @@ export function buildComponentRegistryFromParsing(
     }
     stats.byType[component.type] = (stats.byType[component.type] || 0) + 1;
   }
-
-  const total = stats.exported + stats.inline;
-
   return registry;
 }