Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
|
TL;DR — Renames the UI package from Key changes
Summary ｜ 16 files ｜ 6 commits ｜ base: |
|
TL;DR — Renames the chat component package from Key changes
Summary ｜ 18 files ｜ 2 commits ｜ base: Package rename across chat component documentation
This is a mechanical find-and-replace touching install commands (
|
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
There was a problem hiding this comment.
The documentation find-and-replace from @inkeep/agents-ui to @inkeep/agents-ui-cloud looks correct across all 16 MDX files. One blocking issue: the lockfile is missing a resolution for the newly added @inkeep/agents-ui-cloud dependency, which will cause the AutoTypeTable type references to fail during the docs build.
There was a problem hiding this comment.
PR Review Summary
(0) Total Issues | Risk: Low
Delta review scope: 1 commit since last review — 5772f059b fix: regenerate lockfile with @inkeep/agents-ui-cloud resolution
The lockfile fix correctly addresses the blocking issue raised by pullfrog. The new commit adds:
- Importer entry for
@inkeep/agents-ui-cloudunderagents-docs - Package resolution for
@inkeep/agents-ui-cloud@0.15.19 - Complete snapshot entry with transitive dependencies
The resolution shows that @inkeep/agents-ui-cloud depends on @inkeep/agents-ui internally, which explains why both packages are retained in package.json.
🕐 Pending Recommendations (1)
- 🧹
concepts.mdx:232Pre-existing inconsistency: Architecture section still referencesagents-uiinstead ofagents-ui-cloud
✅ APPROVE
Summary: The lockfile regeneration correctly resolves @inkeep/agents-ui-cloud for the docs build. The blocking issue from the prior review is addressed. The optional consistency improvement in concepts.mdx remains as a pending suggestion from the prior review — it can be addressed in a follow-up if desired.
Reviewers (0)
| Reviewer | Returned | Main Findings | Consider | While You're Here | Inline Comments | Pending Recs | Discarded |
|---|---|---|---|---|---|---|---|
| (none dispatched — delta is lockfile-only) | — | — | — | — | — | — | — |
Note: No domain reviewers dispatched — the delta consists solely of a lockfile regeneration to address prior feedback.
…ing dist types declarations)
There was a problem hiding this comment.
PR Review Summary
(0) Total Issues | Risk: Low
Delta review scope: 1 commit since last review — f0d5ac8dd fix: use @inkeep/agents-ui/types in AutoTypeTable (cloud package missing dist types declarations)
Analysis
The latest commit correctly addresses a build issue: the @inkeep/agents-ui-cloud package is missing dist type declarations, so AutoTypeTable components couldn't resolve types from @inkeep/agents-ui-cloud/types. The fix reverts the 11 AutoTypeTable type paths back to @inkeep/agents-ui/types while keeping all user-facing documentation (install commands, import statements, code examples) pointed at @inkeep/agents-ui-cloud.
Final state of this PR:
| Surface | Package referenced | Why |
|---|---|---|
| Install commands | @inkeep/agents-ui-cloud ✓ |
Users install the cloud package |
| Import statements in examples | @inkeep/agents-ui-cloud ✓ |
Users import from cloud package |
| CDN script URLs | @inkeep/agents-ui-cloud-js ✓ |
Users use cloud CDN |
AutoTypeTable type resolution (build-time) |
@inkeep/agents-ui |
Internal workaround — cloud package missing dist types |
This is a reasonable workaround. Both packages are retained in package.json to support this split.
🕐 Pending Recommendations (1)
- 🧹
concepts.mdx:232Pre-existing inconsistency: Architecture section still referencesagents-uiinstead ofagents-ui-cloud
✅ APPROVE
Summary: Clean documentation migration complete. The AutoTypeTable workaround is pragmatic given the cloud package's missing dist type declarations — this is an internal build concern that doesn't affect the documented developer experience. The optional concepts.mdx consistency update remains as a pending suggestion from the prior review.
Reviewers (0)
| Reviewer | Returned | Main Findings | Consider | While You're Here | Inline Comments | Pending Recs | Discarded |
|---|---|---|---|---|---|---|---|
| (none dispatched — delta is mechanical workaround) | — | — | — | — | — | — | — |
Note: No domain reviewers dispatched — the delta consists solely of a type resolution workaround for AutoTypeTable build failures.
…kage missing type declarations)
There was a problem hiding this comment.
PR Review Summary
(0) Total Issues | Risk: Low
Delta review scope: 1 commit since last review — d2762bd83 fix: revert AutoTypeTable type= attrs to @inkeep/agents-ui (cloud package missing type declarations)
Analysis
The latest commit continues the same workaround pattern already reviewed and approved: reverting AutoTypeTable type paths from @inkeep/agents-ui-cloud back to @inkeep/agents-ui because the cloud package lacks dist type declarations needed for build-time prop table generation.
Changes in delta (12 files):
All changes are mechanical reversions of AutoTypeTable type attributes:
@inkeep/agents-ui-cloud→@inkeep/agents-ui(component prop types)@inkeep/agents-ui-cloud/types→@inkeep/agents-ui/types(settings types)
Final state remains consistent:
| Surface | Package | Rationale |
|---|---|---|
| Install commands | @inkeep/agents-ui-cloud ✓ |
Users install cloud package |
| Import statements | @inkeep/agents-ui-cloud ✓ |
Users import from cloud package |
| CDN script URLs | @inkeep/agents-ui-cloud-js ✓ |
Users use cloud CDN |
AutoTypeTable type resolution |
@inkeep/agents-ui |
Build-time workaround — cloud package missing dist types |
🕐 Pending Recommendations (1)
- 🧹
concepts.mdx:232Pre-existing inconsistency: Architecture section still referencesagents-uiinstead ofagents-ui-cloud
✅ APPROVE
Summary: Clean continuation of the same mechanical workaround already approved. The delta contains no new logic or issues — just additional AutoTypeTable type path reversions across more component documentation files. The optional concepts.mdx consistency update remains as a pending suggestion from the initial review. 🚀
Reviewers (0)
| Reviewer | Returned | Main Findings | Consider | While You're Here | Inline Comments | Pending Recs | Discarded |
|---|---|---|---|---|---|---|---|
| (none dispatched — delta is mechanical workaround) | — | — | — | — | — | — | — |
Note: No domain reviewers dispatched — the delta consists solely of additional AutoTypeTable type path reversions, continuing the same pattern reviewed in the prior commit.
sarah-inkeep
left a comment
sarah-inkeep
left a comment
There was a problem hiding this comment.
For the js package, it should be agents-ui-js-cloud instead of agents-ui-cloud-js
There was a problem hiding this comment.
PR Review Summary
(0) Total Issues | Risk: Low
Delta review scope: 1 commit since last review — 36561e284 fix: correct JS CDN package name to @inkeep/agents-ui-js-cloud
Analysis
This commit directly addresses sarah-inkeep's CHANGES_REQUESTED feedback. The JavaScript CDN package name has been corrected from @inkeep/agents-ui-cloud-js to @inkeep/agents-ui-js-cloud across all 4 JavaScript documentation files:
| File | Change |
|---|---|
javascript/chat-button.mdx |
✅ agents-ui-cloud-js → agents-ui-js-cloud |
javascript/custom-trigger.mdx |
✅ agents-ui-cloud-js → agents-ui-js-cloud |
javascript/embedded-chat.mdx |
✅ agents-ui-cloud-js → agents-ui-js-cloud |
javascript/side-bar-chat.mdx |
✅ agents-ui-cloud-js → agents-ui-js-cloud |
Final state of this PR:
| Surface | Package | Status |
|---|---|---|
| Install commands (React/Next.js) | @inkeep/agents-ui-cloud |
✓ Correct |
| Import statements in examples | @inkeep/agents-ui-cloud |
✓ Correct |
| CDN script URLs (JavaScript) | @inkeep/agents-ui-js-cloud |
✓ Fixed |
AutoTypeTable type resolution |
@inkeep/agents-ui |
✓ Workaround (cloud package missing dist types) |
🕐 Pending Recommendations (1)
- 🧹
concepts.mdx:232Pre-existing inconsistency: Architecture section still referencesagents-uiinstead ofagents-ui-cloud
✅ APPROVE
Summary: The blocking issue from sarah-inkeep's review is now resolved — JavaScript CDN URLs correctly reference @inkeep/agents-ui-js-cloud. The PR is ready to merge. 🚀 The optional concepts.mdx consistency update remains as a pending suggestion from the initial review — it can be addressed in a follow-up if desired.
Reviewers (0)
| Reviewer | Returned | Main Findings | Consider | While You're Here | Inline Comments | Pending Recs | Discarded |
|---|---|---|---|---|---|---|---|
| (none dispatched — delta is fix-only) | — | — | — | — | — | — | — |
Note: No domain reviewers dispatched — the delta consists solely of a naming correction (agents-ui-cloud-js → agents-ui-js-cloud) to address prior human feedback.
|
🔎💬 Inkeep AI search and chat service is syncing content for source 'Inkeep Agent Framework Docs' |
2 participants
Summary
@inkeep/agents-uireferences with@inkeep/agents-ui-cloudacross chat component docs (install instructions, imports,AutoTypeTabletype references)@inkeep/agents-ui-cloudas a dependency inagents-docs/package.jsonfor type resolution at build timeCloses PRD-6347