Skip to content

Conversation

@rafal-ch
Copy link
Contributor

@rafal-ch rafal-ch commented Nov 6, 2025

Description

This PR adapts the Hermes code to the recently released hermes-ipfs version 0.0.6.

Related Issue(s)

Closes #647

Breaking Changes

previously currently
Events contained the topic Events no longer contain topic since given stream will only contain events related to a particular topic. To keep the backward compatibility with the Hermes code I introduced the stateful handlers which hold the info about topic. At some point we may want to rebuild Hermes extensions and this additional layer could be removed

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@rafal-ch rafal-ch changed the title wip: IPFS changes chore(deps): Update to hermes-ipfs version 0.0.6 Nov 7, 2025
@rafal-ch rafal-ch added this to Catalyst Nov 7, 2025
@rafal-ch rafal-ch moved this from New to 👀 In review in Catalyst Nov 7, 2025
@rafal-ch rafal-ch marked this pull request as ready for review November 7, 2025 14:55
aido-mth
aido-mth previously approved these changes Nov 7, 2025
Copy link
Contributor

@aido-mth aido-mth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. removal of MessageId looks strange but will see how new version works without it.

autonumber
backpressure
bech
Behaviour
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Behaviour
behaviour

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll keep it because it's exactly how it appears in the code, if you don't mind.

aido-mth
aido-mth previously approved these changes Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 👀 In review

Development

Successfully merging this pull request may close these issues.

🛠️ [TASK]: Make Hermes compatible with the IPFS changes in "catalyst-libs"

4 participants