Skip to content

Release io-classes-1.8 #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 21, 2025
Merged

Release io-classes-1.8 #213

merged 9 commits into from
May 21, 2025

Conversation

coot
Copy link
Collaborator

@coot coot commented May 15, 2025

  • Reworded CHANGELOG.md
  • io-classes: prefixed sublibraries
  • Bump versions to 1.8.0.0

@coot coot force-pushed the coot/io-classes-1.8 branch from dcabafc to e8eb0e0 Compare May 16, 2025 07:58
@coot coot force-pushed the coot/io-classes-1.8 branch from e8eb0e0 to 4200ec2 Compare May 16, 2025 08:47
@coot coot requested a review from Copilot May 16, 2025 08:48
@coot coot self-assigned this May 16, 2025
@coot coot marked this pull request as ready for review May 16, 2025 08:48
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates version 1.8.0.0 of both io-sim and io-classes packages, rewording the CHANGELOG and renaming sublibraries to include the "io-classes-" prefix.

  • Updated version numbers and dependency constraints in cabal files.
  • Renamed libraries in io-classes and updated corresponding dependencies in io-sim.
  • Revised CHANGELOGs with new release information.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
io-sim/src/Control/Monad/IOSim/Types.hs Added explicit type signature for traceMVarIO; refactored helper functions.
io-sim/io-sim.cabal Updated version and dependency references to renamed io-classes sublibraries.
io-sim/CHANGELOG.md Reworded release section and updated changelog details.
io-classes/io-classes.cabal Bumped version and renamed libraries to include "io-classes-" prefix.
io-classes/CHANGELOG.md Updated changelog with new release notes and sublibrary renaming.
cabal.project Adjusted the ghc version condition, which differs from the changelog note.
Comments suppressed due to low confidence (1)

cabal.project:15

  • The ghc version condition was changed to '>= 9.10.2', but the changelog indicates support for ghc-9.12. Please verify that this lower bound is intentional and update the documentation accordingly.
if impl (ghc >= 9.10.2)

@coot coot force-pushed the coot/io-classes-1.8 branch from 4200ec2 to 36d7447 Compare May 16, 2025 08:50
@coot coot requested a review from crocodile-dentist May 16, 2025 08:52
@coot coot force-pushed the coot/io-classes-1.8 branch from 49445d7 to a2cdd8a Compare May 16, 2025 09:45
@coot coot enabled auto-merge May 16, 2025 11:22
@coot coot force-pushed the coot/io-classes-1.8 branch 3 times, most recently from 80e4b27 to 4dfee28 Compare May 19, 2025 07:21
@jorisdral
Copy link
Contributor

jorisdral commented May 19, 2025

Hiya, I wanted to ask why the sub-libraries are renamed? IIUC, there's no way in cabal to say "depend on io-classes:strict-mvar ^>= 1.7 or depend on io-classes:io-classes-strict-mvar ^>=1.8". So changing a sub-library name means a dependent package could never support both the old and new sublibrary. It's kind of similar to re-uploading a package to Hackage under a new name, and deprecating the old one. There'd also be no way to support both the old and new package

Feel free to do with this info what you want of course -- maybe you've already considered what I said. I wanted to point it out just in case

@coot
Copy link
Collaborator Author

coot commented May 19, 2025

Because the support for named sub-libraries in haskell.nix is poor at this stage, e.g. io-classes:mtl can be confused with mtl :/.

@jorisdral
Copy link
Contributor

I had a feeling that was the reason, thanks for the info!

@coot
Copy link
Collaborator Author

coot commented May 21, 2025

With input-output-hk/haskell.nix#2363 we might not need the new prefixes.

@coot coot disabled auto-merge May 21, 2025 08:37
@coot coot force-pushed the coot/io-classes-1.8 branch from 4dfee28 to aef1125 Compare May 21, 2025 12:51
@coot
Copy link
Collaborator Author

coot commented May 21, 2025

The issue is fixed, I dropped the prefixes 😄.

@coot coot enabled auto-merge May 21, 2025 12:52
Copy link
Contributor

@jasagredo jasagredo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except the MonadTraceMVar (IOSim s) instance, all changes are removing only Pragmas so it looks fine. The changes there also look reasonable.

@coot coot added this pull request to the merge queue May 21, 2025
Merged via the queue into main with commit 9dbe23e May 21, 2025
14 checks passed
@coot coot deleted the coot/io-classes-1.8 branch May 21, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants