-
Notifications
You must be signed in to change notification settings - Fork 19
Release io-classes-1.8 #213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
coot
commented
May 15, 2025
- Reworded CHANGELOG.md
- io-classes: prefixed sublibraries
- Bump versions to 1.8.0.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates version 1.8.0.0 of both io-sim and io-classes packages, rewording the CHANGELOG and renaming sublibraries to include the "io-classes-" prefix.
- Updated version numbers and dependency constraints in cabal files.
- Renamed libraries in io-classes and updated corresponding dependencies in io-sim.
- Revised CHANGELOGs with new release information.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
io-sim/src/Control/Monad/IOSim/Types.hs | Added explicit type signature for traceMVarIO; refactored helper functions. |
io-sim/io-sim.cabal | Updated version and dependency references to renamed io-classes sublibraries. |
io-sim/CHANGELOG.md | Reworded release section and updated changelog details. |
io-classes/io-classes.cabal | Bumped version and renamed libraries to include "io-classes-" prefix. |
io-classes/CHANGELOG.md | Updated changelog with new release notes and sublibrary renaming. |
cabal.project | Adjusted the ghc version condition, which differs from the changelog note. |
Comments suppressed due to low confidence (1)
cabal.project:15
- The ghc version condition was changed to '>= 9.10.2', but the changelog indicates support for ghc-9.12. Please verify that this lower bound is intentional and update the documentation accordingly.
if impl (ghc >= 9.10.2)
80e4b27
to
4dfee28
Compare
Hiya, I wanted to ask why the sub-libraries are renamed? IIUC, there's no way in cabal to say "depend on Feel free to do with this info what you want of course -- maybe you've already considered what I said. I wanted to point it out just in case |
Because the support for named sub-libraries in |
I had a feeling that was the reason, thanks for the info! |
With input-output-hk/haskell.nix#2363 we might not need the new prefixes. |
The issue is fixed, I dropped the prefixes 😄. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except the MonadTraceMVar (IOSim s)
instance, all changes are removing only Pragmas so it looks fine. The changes there also look reasonable.