Skip to content

Fix: include the two latest ledger state snapshots in the ancillary archive #2484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 16, 2025

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented May 15, 2025

Content

This PR includes a fix that adds the two most recent ledger state snapshots to the ancillary archive.
It improves the reliability of Cardano node fast bootstrap, preventing full chain replays when restarting the node.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)
    • Add ADR blog post or Dev ADR entry (if relevant)
    • No new TODOs introduced

Issue(s)

Closes #2474

@dlachaume dlachaume self-assigned this May 15, 2025
Copy link

github-actions bot commented May 15, 2025

Test Results

    3 files  ±0     57 suites  ±0   11m 7s ⏱️ -26s
1 913 tests +1  1 913 ✅ +1  0 💤 ±0  0 ❌ ±0 
2 393 runs  +1  2 393 ✅ +1  0 💤 ±0  0 ❌ ±0 

Results for commit 8e13f58. ± Comparison against base commit 4d382b9.

This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both.
mithril-aggregator ‑ services::snapshotter::compressed_archive_snapshotter::tests::snapshot_ancillary::create_archive_should_embed_only_last_ledger_and_last_immutables
mithril-aggregator ‑ services::snapshotter::compressed_archive_snapshotter::tests::snapshot_ancillary::create_archive_should_embed_only_two_last_ledgers_and_last_immutables
mithril-aggregator ‑ services::snapshotter::compressed_archive_snapshotter::tests::snapshot_ancillary::getting_files_to_include_fails_when_no_ledger_file_found

♻️ This comment has been updated with latest results.

Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dlachaume dlachaume force-pushed the dlachaume/2474/fix-invalid-snapshot-ledger-state branch from 4f652a9 to 21d837e Compare May 15, 2025 14:35
@dlachaume dlachaume temporarily deployed to testing-preview May 15, 2025 14:48 — with GitHub Actions Inactive
Copy link
Collaborator

@turmelclem turmelclem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Alenar Alenar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dlachaume added 2 commits May 16, 2025 10:17
* mithril-aggregator from `0.7.51` to `0.7.52`
@dlachaume dlachaume force-pushed the dlachaume/2474/fix-invalid-snapshot-ledger-state branch from 21d837e to 8e13f58 Compare May 16, 2025 08:17
@dlachaume dlachaume temporarily deployed to testing-preview May 16, 2025 08:34 — with GitHub Actions Inactive
@dlachaume dlachaume merged commit 7c1f5aa into main May 16, 2025
38 checks passed
@dlachaume dlachaume deleted the dlachaume/2474/fix-invalid-snapshot-ledger-state branch May 16, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some Cardano DB snapshots require full chain replay
4 participants