ETCM-12351 some dolos fixes #1088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

kpinter-iohk wants to merge 12 commits into master from ETCM-12351-dolos-data-source-fixes

Contributor

kpinter-iohk commented Nov 7, 2025 •

edited

Loading

Description

Fixes some bugs in existing dolos data sources.

Checklist

Commit sequence broadly makes sense and commits have useful messages.
The size limit of 400 LOC isn't needlessly exceeded
The PR refers to a JIRA ticket (if one exists)
New tests are added if needed and existing tests are updated.
New code is documented and existing documentation is updated.
Relevant logging and metrics added
Any changes are noted in the changelog.md for affected crate
Self-reviewed the diff

kpinter-iohk force-pushed the ETCM-12351-dolos-data-source-fixes branch 2 times, most recently from 731d279 to ff3d817 Compare

November 12, 2025 14:54

kpinter-iohk changed the title ~~ETCM-12351 some dolos fixes + diff data source~~ ETCM-12351 some dolos fixes

kpinter-iohk marked this pull request as ready for review

November 12, 2025 15:43

alexromanov reviewed

View reviewed changes

toolkit/data-sources/dolos/src/block.rs Show resolved Hide resolved

LGLO reviewed

View reviewed changes

demo/node/src/data_sources.rs Show resolved Hide resolved

LGLO reviewed

View reviewed changes

toolkit/data-sources/dolos/src/block.rs Outdated Show resolved Hide resolved

LGLO reviewed

View reviewed changes

toolkit/data-sources/dolos/src/block.rs Show resolved Hide resolved

LGLO reviewed

View reviewed changes

toolkit/data-sources/dolos/src/block.rs Outdated Show resolved Hide resolved

LGLO reviewed

View reviewed changes

toolkit/data-sources/dolos/src/block.rs Outdated Show resolved Hide resolved

LGLO reviewed

View reviewed changes

toolkit/data-sources/dolos/src/block.rs Show resolved Hide resolved

kpinter-iohk force-pushed the ETCM-12351-dolos-data-source-fixes branch from 387d823 to a87ddf0 Compare

November 13, 2025 14:10

kpinter-iohk requested review from LGLO and alexromanov

November 13, 2025 14:17

alexromanov approved these changes

View reviewed changes

kpinter-iohk added 12 commits

November 14, 2025 17:02


          some fixes + diff data source

0e92266


          fixes

a5a545e


          add block caching


          remove diff sources

9f129e1


          fix docstrings

64ebe1b


          address comments

477da44


          better errors

1441b3a


          upgrade to dolos rc2

edaa6ec


          formatting

7570d44

fix

7b29bcd


          api cleanup

3e3d7f9


          fixes

5beac89

kpinter-iohk force-pushed the ETCM-12351-dolos-data-source-fixes branch from 11aec03 to 5beac89 Compare

November 14, 2025 16:02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet