change: ETCM-12419 decouple sidechain-rpc from slots #1095
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes dependency on slots crates from
pallet-sidechain-rpc(sidechain_getStatus) by:sp_sidechain::GetEpochDurationApiand computing current/next PC epoch using it instead of slotssidechain.slotfrom the response by defaultlegacy-compatwhich adds the ability to read epoch duration / slots per epoch using raw calls toSlotApiand re-adds thesidechain.slotfield as optionalThe backward compatibility aspect of this PR is probably not really needed here, but we'll need to do the same in other parts of the codebase that are more important (eg. committee selection IDP needs access to epoch duration data, which for old blocks will need to be computed based on slot configuration exposed via
SlotApi).Checklist
changelog.mdfor affected crate