Seed data creation and data preprocessing improvements #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ali Maredia <[email protected]>
create_seed_dataset.py used in this notebook is heavily inspired by docprocessor.py from the sdg-hub repo. Co-authored-by: Abhishek B <[email protected]> Co-authored-by: shiv <[email protected]> Signed-off-by: Ali Maredia <[email protected]>
alimaredia
force-pushed
the
seed-data-creation-and-data-preprocessing-improvements
branch
from
871297c to
0058f67
Compare
fabianofranz
approved these changes
Apr 25, 2025
| chunk_files = path.glob('*.txt') | ||
|
|
||
| chunks_dict = {} | ||
| for file in chunk_files: |
There was a problem hiding this comment.
Is the file order important here? I don't think it is, but if it is, afaik glob lists in arbitrary order.
| {"chunks": "document"} | ||
| ) | ||
|
|
||
| # Only keep document greater than 100 tokens |
There was a problem hiding this comment.
Nit, it would be nice to have a comment about why we need to do this.
Signed-off-by: Ali Maredia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR 1) Adds a notebook that combines qna.yaml's and chunks into the seed_data.jsonl that is consumed by notebooks like this one in sdg-hub and 2) Addresses issues from the previously merged conversion and chunking notebooks.