Support callable signing_secrets for dynamic configuration#177
Open
kristinemcbride wants to merge 1 commit into
Open
Support callable signing_secrets for dynamic configuration#177kristinemcbride wants to merge 1 commit into
kristinemcbride wants to merge 1 commit into
Conversation
Allow signing_secrets to accept lambdas/procs that are resolved at request time. This enables multi-region deployments or dynamic configuration scenarios where signing secrets may vary per request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Multi-tenant Rails applications often need to use different Stripe webhook signing secrets for different tenants/regions. Currently, signing_secrets must be set to a static array at boot time, which doesn't work well for applications where the correct signing secrets are only known at request time.
This change allows signing_secrets to accept a callable (lambda/proc) that is evaluated on each webhook request, enabling dynamic resolution of signing secrets based on the current request context.
What?
After this change, applications can configure StripeEvent like this:
See Also
activerecord-tenanted - This is the gem I am using that enables multi-tenant Rails applications, which is an example use case for this feature.