Add safety check for line breaks after single-line comments #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discovered recently (integrated-application-development#181), it's possible for subtle bugs to slip in that result in a missing line break after a single-line comment. While we strive to never let this happen, it's a good idea to make *sure* that it doesn't happen. With this change, the missing line break will be detected and inserted. The formatting won't be great after a line break is suddenly inserted, but that's better than broken.
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
zaneduffield
merged commit 97a4128
into
integrated-application-development:master
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discovered recently (#181), it's possible for subtle bugs to slip in
that result in a missing line break after a single-line comment.
While we strive to never let this happen, it's a good idea to make
sure that it doesn't happen. With this change, the missing line break
will be detected and inserted. The formatting won't be great after a
line break is suddenly inserted, but that's better than broken.