Fix parsing ambiguity around adjacent >
and =
tokens
#335
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a grammar ambiguity around adjacent
>
and=
tokens. (Fixes #318)We now create
>=
tokens during parsing by combining the>
/=
tokens, instead of combining them at the lexing stage.(For consistently, we're doing this for "less than equal" tokens as well)
This allows us to only create
>=
tokens when we're parsing a binary expression.As a result, we can now successfully parse code that looks like this:
Previously this would create a
>=
token in the middle and make everything fall over.