Fix parsing errors around attributes on visibility sections - #467
Merged
cirras merged 1 commit intoSep 22, 2026
Conversation
Bazooper-blip
force-pushed
the
fix/461-visibility-section-attributes
branch
from
September 21, 2026 19:09
fae84a2 to
857c482
Compare
cirras
force-pushed
the
fix/461-visibility-section-attributes
branch
from
September 22, 2026 00:03
857c482 to
866b330
Compare
cirras
self-requested a review
September 22, 2026 00:23
cirras
merged commit Sep 22, 2026
b551f6e
into
integrated-application-development:master
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes parsing errors on attributes that precede visibility specifiers or
varsections in class bodies.These attribute lists are parsed as standalone items and their names are resolved, but they are not yet associated with the next declared member (per @fourls's findings in the issue). I've left that out of scope here.
I don't have access to a Delphi 13 compiler at the moment, so the test fixture is limited to the forms confirmed in the issue thread.
Fixes #461.