Add missed parameter to the github_organization_ruleset #2545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be nice to have this merged. Can someone review it? |
|
@kfcampbell Can we please get this fix merged and released? |
|
Hi @kfcampbell can you please review and merge this? |
|
@yurii-kysel Should probably also update https://github.com/integrations/terraform-provider-github/blob/main/website/docs/r/organization_ruleset.html.markdown in this PR, too |
1 task
|
fairly sure this PR fixes #2597 - would be great to have it approved/merged :) |
|
oh and #2542 would get closed out too (already linked) |
dcreey
reviewed
May 7, 2025
| @@ -261,6 +261,12 @@ func resourceGithubOrganizationRuleset() *schema.Resource { | |||
| Optional: true, | |||
| Description: "Whether pull requests targeting a matching branch must be tested with the latest code. This setting will not take effect unless at least one status check is enabled. Defaults to `false`.", | |||
| }, | |||
| "do_not_enforce_on_create": { | |||
There was a problem hiding this comment.
We actually also need it on the required_workflows struct too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2542
Before the change?
github_organization_rulesetthat cause an error, as it's required inrespository_rules_utils.expandRulesAfter the change?
github_organization_rulesetwith the default valuePull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!