fix: ensure baseUrl is not already prefixed (#2616) #2620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For self-hosted github (i.e with host different than https://api.github.com/) in the NewRESTClient func the "api/v3/" suffix is automatically added. However in the `getInstallationAccessToken` the same check is done. This results in have a double suffix. This fix ensure it is not added if already existing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2616
Before the change?
NewRESTClientfunc theapi/v3/suffix is automatically added. However in thegetInstallationAccessTokenthe same check is done. This results in have a double suffix and thus break the api callAfter the change?
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!