Fix Support for Github Environment Secrets' Lifecycle Ignore Changes #2651
+166
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2288
Before the change?
Modifying a Github Environment Secret value from Terraform OR Externally in Github while using a
lifecycle
ignore_changes
block always results in Secret creation.After the change?
Modifying a Github Environment Secret value from Terraform OR Externally in Github no longer causes Secret creation, and the
lifecycle
ignore_changes
block is respected.Notably, with this change a
terraform plan
without theignore_changes
now appropriately states that a Github Environment Secret value must be replaced rather than just "created".Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!
Manual test Terraform code (expand)