remove extra error log #645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
|
Comment: Please split this PR to two separated PRs.
Question: What is expectation for "log::error!" now? |
haitaohuang
force-pushed
the
intel_tracking
branch
2 times, most recently
from
0ed3a86 to
a07f6f6
Compare
haitaohuang
changed the title
Contributor
Author
Will only fix log for this PR. |
haitaohuang
force-pushed
the
intel_tracking
branch
2 times, most recently
from
d5b47af to
c17088c
Compare
jyao1
approved these changes
Nov 27, 2025
Contributor
|
@haitaohuang please resolve conflict. |
Contributor
Author
|
I'll rebase |
Contributor
|
@haitaohuang , please do not use "merge direct" (Merge branch 'main' into intel_tracking) is not acceptable. Please always use "rebase and merge". |
Signed-off-by: Haitao Huang <[email protected]>
haitaohuang
force-pushed
the
intel_tracking
branch
from
5314d54 to
010a47d
Compare
Contributor
Author
|
done rebasing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.