Skip to content

Conversation

@agokarn
Copy link
Contributor

@agokarn agokarn commented Dec 12, 2025

IGVM_FEATURES_BASE should not use have igvm-attest feature enabled. This is used only when a direct call needs to be made to GHCI for getting the quote from main.rs.

We want to have the option in vmcall-raw to be able to go through the default path which uses servtd code path and calls GHCI from there.

@agokarn agokarn requested a review from jyao1 as a code owner December 12, 2025 23:56
@jyao1
Copy link
Contributor

jyao1 commented Dec 15, 2025

@agokarn , please add description or issue for this fix.

Copy link
Contributor

@jyao1 jyao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please split temp feature from this PR.

Adding log is irrelevant.

temp changes

Remove extra files

	modified:   sh_script/Azure/Makefile
@agokarn agokarn force-pushed the user/arthig/enable-trace-logging-for-Azure branch from d01cb8e to d9c463d Compare December 16, 2025 03:00
@agokarn
Copy link
Contributor Author

agokarn commented Dec 16, 2025

Please split temp feature from this PR.

Adding log is irrelevant.

removed them

@jyao1 jyao1 merged commit d7fe310 into intel:main Dec 16, 2025
47 checks passed
@agokarn agokarn deleted the user/arthig/enable-trace-logging-for-Azure branch December 16, 2025 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants