Skip to content

Avoid use vdm payload struct with slices #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
IntelCaisui wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Avoid use vdm payload struct with slices #679

IntelCaisui wants to merge 1 commit into from

Conversation

@IntelCaisui
Copy link
Contributor

@IntelCaisui IntelCaisui commented Dec 18, 2025

To reduce the stack size consumed by avoid allocating large slices
caused by vdm structs have includes vdm payload slices.

@IntelCaisui
Copy link
Contributor Author

IntelCaisui commented Dec 18, 2025 •
edited
Loading

Ready to review.
Stack consumption update.
MigTd spdm attestation 1 session with policy v2 update
Rsp.
max stack usage: b3f38
max heap usage: 140c07
Req.
max stack usage: 8a2a8
max heap usage: 15ef8e

Reducing about 50% stack usage after this updating spdm-rs.

@IntelCaisui IntelCaisui force-pushed the 201218_MIGTD_STACK_VDM_PAYLOAD_IMPR branch 3 times, most recently from fc5abec to 576a30b Compare December 25, 2025 07:54
@IntelCaisui IntelCaisui marked this pull request as ready for review December 25, 2025 08:30
@IntelCaisui IntelCaisui requested a review from jyao1 as a code owner December 25, 2025 08:30
@IntelCaisui IntelCaisui force-pushed the 201218_MIGTD_STACK_VDM_PAYLOAD_IMPR branch from 576a30b to 23c1adf Compare December 25, 2025 09:29
@IntelCaisui
Avoid use vdm payload struct with slices
bb01e01 
To reduce the stack size consumed by avoid allocating large slices
  caused by vdm structs have includes vdm payload slices.
Update the spdm-rs call extend vdm request api to support passing
  vdm payload as u8 array reference.
@IntelCaisui IntelCaisui force-pushed the 201218_MIGTD_STACK_VDM_PAYLOAD_IMPR branch from 23c1adf to bb01e01 Compare December 25, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jyao1 jyao1 Awaiting requested review from jyao1 jyao1 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@IntelCaisui