Upgrade TMA metrics for GNR - #388
Merged
Merged
Conversation
Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
harp-intel
marked this pull request as draft
June 20, 2025 13:48
harp-intel
marked this pull request as ready for review
June 20, 2025 14:00
Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
…ric expressions Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades TMA metrics for the Granite Rapids (GNR) platform by adding retire-latency support and refreshing scripts and definitions for event/metric translation and formatting.
- Add and load
*_retire_latency.jsondata and replace[event:retire_latency]constants in expressions - Enhance
perfmonmetrics2perfspect.pyandperfmonevents2perfspect.pywith prefix stripping, parentheses checks, and improved CLI handling - Update GNR metric JSON (
gnr.json), retire-latency JSON, and event list TXT (gnr.txt) with new and revised metrics/events - Inject inline-comment stripping in
event_defs.goand wire TXN as an uncollectable event
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/perfmonmetrics2perfspect.py | Strip metric_ prefix, validate parentheses, and skip ill-formed metrics |
| scripts/perfmonevents2perfspect.py | Refactor format_event, inline usage message update, and optional file logic |
| scripts/check_events.py | Add "TXN" to core-event filter |
| cmd/metrics/metric_defs.go | Load retire latencies, replace [n] constants with regex, adjust transforms |
| cmd/metrics/event_defs.go | Strip end-of-line comments before parsing event definitions |
Comments suppressed due to low confidence (2)
cmd/metrics/metric_defs.go:108
- [nitpick] The variable name
reConstantIntis ambiguous; consider renaming it to something more descriptive likereBracketedNumberto clarify its purpose.
reConstantInt := regexp.MustCompile(`\[(\d+)\]`)
scripts/perfmonmetrics2perfspect.py:76
- Indentation for the
elseblock is inconsistent with theifbranch above, causing a Python syntax error. Align this line to match the 8-space indent used in theifbranch.
metric["name"] = m["LegacyName"]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.