Skip to content

Upgrade TMA metrics for GNR - #388

Merged
harp-intel merged 21 commits into
mainfrom
gnrtma
Jun 23, 2025
Merged

Upgrade TMA metrics for GNR#388
harp-intel merged 21 commits into
mainfrom
gnrtma

Conversation

@harp-intel

Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
@harp-intel
harp-intel marked this pull request as draft June 20, 2025 13:48
@harp-intel
harp-intel marked this pull request as ready for review June 20, 2025 14:00
@harp-intel
harp-intel requested a review from Copilot June 23, 2025 16:44

This comment was marked as outdated.

Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
…ric expressions

Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
@harp-intel
harp-intel requested a review from Copilot June 23, 2025 17:08

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades TMA metrics for the Granite Rapids (GNR) platform by adding retire-latency support and refreshing scripts and definitions for event/metric translation and formatting.

  • Add and load *_retire_latency.json data and replace [event:retire_latency] constants in expressions
  • Enhance perfmonmetrics2perfspect.py and perfmonevents2perfspect.py with prefix stripping, parentheses checks, and improved CLI handling
  • Update GNR metric JSON (gnr.json), retire-latency JSON, and event list TXT (gnr.txt) with new and revised metrics/events
  • Inject inline-comment stripping in event_defs.go and wire TXN as an uncollectable event

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
scripts/perfmonmetrics2perfspect.py Strip metric_ prefix, validate parentheses, and skip ill-formed metrics
scripts/perfmonevents2perfspect.py Refactor format_event, inline usage message update, and optional file logic
scripts/check_events.py Add "TXN" to core-event filter
cmd/metrics/metric_defs.go Load retire latencies, replace [n] constants with regex, adjust transforms
cmd/metrics/event_defs.go Strip end-of-line comments before parsing event definitions
Comments suppressed due to low confidence (2)

cmd/metrics/metric_defs.go:108

  • [nitpick] The variable name reConstantInt is ambiguous; consider renaming it to something more descriptive like reBracketedNumber to clarify its purpose.
	reConstantInt := regexp.MustCompile(`\[(\d+)\]`)

scripts/perfmonmetrics2perfspect.py:76

  • Indentation for the else block is inconsistent with the if branch above, causing a Python syntax error. Align this line to match the 8-space indent used in the if branch.
            metric["name"] = m["LegacyName"]

Comment thread scripts/perfmonevents2perfspect.py
Comment thread scripts/perfmonevents2perfspect.py
Comment thread cmd/metrics/metric_defs.go
@harp-intel
harp-intel merged commit 92e4586 into main Jun 23, 2025
4 checks passed
@harp-intel
harp-intel deleted the gnrtma branch June 26, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants