Prepare metrics for GNR on Cloud VMs - #389
Merged
Merged
Conversation
…lable Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for GraniteRapids (gnr) on cloud VMs by providing new “nofixedtma” metric and event definitions and updating the loader logic to pick these files when fixed TMA counters aren’t available.
- Introduce
gnr_nofixedtma.jsonwith 478 new metric expressions for GraniteRapids without fixed TMA. - Introduce
gnr_nofixedtma.txtwith 214 new event definitions for GraniteRapids. - Extend
LoadMetricDefinitionsandLoadEventGroupsto recognizeuarch == "gnr"and select the_nofixedtmavariants. - Refactor PEBS event filtering in
isCollectableEventto loop on substrings rather than exact matches.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| cmd/metrics/resources/metrics/x86_64/GenuineIntel/gnr_nofixedtma.json | New metrics definitions for GraniteRapids when fixed TMA is unsupported |
| cmd/metrics/resources/events/x86_64/GenuineIntel/gnr_nofixedtma.txt | New event definitions for GraniteRapids when fixed TMA is unsupported |
| cmd/metrics/metric_defs.go | Include gnr in the alternate‐metric selection for no‐fixed‐TMA path |
| cmd/metrics/event_defs.go | Include gnr in the alternate‐event selection and refactor PEBS filtering |
Comments suppressed due to low confidence (4)
cmd/metrics/resources/metrics/x86_64/GenuineIntel/gnr_nofixedtma.json:239
- [nitpick] The metric name uses underscores and camel-case inconsistently compared to other metrics (e.g., "memory bandwidth read (MB/sec)"). Consider renaming to "IO bandwidth disk or network writes (MB/sec)" for consistency.
"name": "IO_bandwidth_disk_or_network_writes (MB/sec)",
cmd/metrics/resources/metrics/x86_64/GenuineIntel/gnr_nofixedtma.json:243
- [nitpick] Similarly, adjust this to "IO bandwidth disk or network reads (MB/sec)" to match the naming style of other metrics.
"name": "IO_bandwidth_disk_or_network_reads (MB/sec)",
cmd/metrics/metric_defs.go:46
- Add a unit test to verify that when
uarch == "gnr"andSupportsFixedTMAis false, the loader correctly selectsgnr_nofixedtma.json.
if (uarch == "icx" || uarch == "spr" || uarch == "emr" || uarch == "gnr") && !metadata.SupportsFixedTMA {
cmd/metrics/event_defs.go:47
- Add a unit test to ensure that
LoadEventGroupspicksgnr_nofixedtma.txtforuarch == "gnr"when fixed TMA is unsupported.
alternate = "_nofixedtma"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.