Skip to content

Add AMD to test scope to verify fallback functionality #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 54 commits into from
Closed

Add AMD to test scope to verify fallback functionality #220

wants to merge 54 commits into from

Conversation

@ethanglaser
Copy link
Member

@ethanglaser ethanglaser commented Nov 14, 2025

No description provided.

rfsaliev and others added 30 commits October 30, 2025 16:59
@rfsaliev
Initial implementation of SVS Runtime package
b2d6285
@ethanglaser
Initial support for private source
71a3f83
@ethanglaser
Point SVS_URL to LTO-enabled tarball
3f95bab
@rfsaliev
Improve svs_runtime CMakeLists.txt to use pre-defined LVQ heades and …
111448e 
…allow non-LTO linking
@rfsaliev
Fixup C++ runtime CMakeLists for internal build
0ca8bbf
@rfsaliev
Apply formatting
923e002
@ethanglaser
Re-add private source build condition
0c490d1
@ethanglaser
Add pipeline to build cpp bindings
0067a3a
@ethanglaser
rename bash script
54fe550
@ethanglaser
add steps to fix yaml error
4d74c8b
@ethanglaser
Change runs-on to ubuntu-22.04
e42d806
@ethanglaser
Add missing repo checkout
8e3b15f
@ethanglaser
clean up copyright/docker files
0a9c3d6
@ethanglaser
set CMAKE_INSTALL_LIBDIR
32d3d9a
@ethanglaser
Add flexibility to gcc version check 11.2.*
f8791dc
@ethanglaser
Add resuable function for linking statically to MKL
473a74b
@rfsaliev
Improved runtime API draft in new header
8966732
@rfsaliev
Update API header with comments
3bbc18c
@ethanglaser
Initial faiss python test validation
0540d00
@ethanglaser
Merge branch 'rfsaliev/cpp-runtime-binding' of https://github.com/int…
a8361cd 
…el/ScalableVectorSearch into rfsaliev/cpp-runtime-binding
@ethanglaser
Fix upload path
d5d6956
@ethanglaser
Actually fix upload path
883266f
@ethanglaser
Add conda env creation
dc6aa10
@rfsaliev
First implementation of the improved runtime Vamana API
ec1cce5
@ethanglaser
Add faiss c++ tests
696519b
@ethanglaser
Merge branch 'rfsaliev/cpp-runtime-binding' of https://github.com/int…
35afd2a 
…el/ScalableVectorSearch into rfsaliev/cpp-runtime-binding
@rfsaliev
Apply formatting
5b2707e
@rfsaliev
Fix LeanVecTrainingData API
fdcffe2
@rfsaliev
Refactored VamanaIndex implementation code
ae0f97d
@rfsaliev
Fix non-filtered case in DynamicVamanaIndex::search()
5ab0758
ethanglaser and others added 24 commits November 6, 2025 08:12
@ethanglaser
rebase
f7fbdfc
@rfsaliev
Add new FlatIndex API and fix abstract interface descructors
ad9bd20
@ethanglaser
Update static library tarball
1a1e2df
@yuejiaointel
feature: add version namespace
a551e9b
@yuejiaointel
fix: add version.h to cmake
bcd7cb3
@ahuber21
Replace macros with runtime_error_wrapper() for error handling (#214)
1d100af 
I think this produces more readable code. And since
`runtime_error_wrapper()` is an internal function, there shouldn't be
any disadvantages for the shared lib.
@rfsaliev
Clang-format
c2181e2
@rfsaliev
Fix Flat index wrapper and LeanVec Training
73c18ab
@rfsaliev
Inline versioning namespace
c7e039f
@rfsaliev
Remove outdated SVS Runtime code
597c4b5
@rfsaliev
Improve Status structure to avoid potential memory leaks
b2c61ba
@rfsaliev
Move public headers to svs/runtime subdir
fc11a3a
@rfsaliev
Fix Status linkage visibility
3e25ae3
@rfsaliev
Fix non-LVQ failures on non-Intel platforms
33bbe21
@rfsaliev
Fix "<mkl.h> not found" compilation error
dfc84a8
@ethanglaser
Update static library/tarball to latest
a65a641
@ethanglaser
Avoid passing exact same LeanVecMatricesType args
1f20a5b
@ethanglaser
Merge branch 'rfsaliev/cpp-runtime-binding' of https://github.com/int…
1c92666 
…el/ScalableVectorSearch into rfsaliev/cpp-runtime-binding
@ethanglaser
Update static library tarball link
df8630f
@ethanglaser
Clean up docker and pipeline
bb0d1b6
@ethanglaser
Pull svs-io branch for validation
4823508
@rfsaliev
Code review s1e1
021badd
@ethanglaser
Add AMD to test scope to verify fallback functionality
4ba20a0
@ethanglaser
temporary size_t -> int64_t for CI
74e3b62
@rfsaliev rfsaliev force-pushed the rfsaliev/cpp-runtime-binding branch from 5cb9050 to f2680de Compare November 19, 2025 10:33
@ethanglaser
Copy link
Member Author

ethanglaser commented Nov 19, 2025

Closing because force push messed up git history :/

@ethanglaser ethanglaser mentioned this pull request Nov 19, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mihaic mihaic Awaiting requested review from mihaic mihaic will be requested when the pull request is marked ready for review mihaic is a code owner

@homksei homksei Awaiting requested review from homksei homksei will be requested when the pull request is marked ready for review homksei is a code owner

@yuejiaointel yuejiaointel Awaiting requested review from yuejiaointel yuejiaointel will be requested when the pull request is marked ready for review yuejiaointel is a code owner

@ahuber21 ahuber21 Awaiting requested review from ahuber21 ahuber21 will be requested when the pull request is marked ready for review ahuber21 is a code owner

@ibhati ibhati Awaiting requested review from ibhati ibhati will be requested when the pull request is marked ready for review ibhati is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ethanglaser @rfsaliev @yuejiaointel @ahuber21