Support runtime bindings build from public source only #225
+56
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I'm not a fan of the conditionals in the API. We already have a runtime check if a storage kind is supported. That is, requesting e.g. LVQ_4x4 on non-Intel will throw a runtime error. We can do the same if LVQ/LeanVec wasn't even compiled in. All interfaces, however, should look the same. |
ahuber21
requested changes
Nov 21, 2025
Contributor
ahuber21
left a comment
ahuber21
left a comment
There was a problem hiding this comment.
The API should not be affected by whether or not LVQ/LeanVec was enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.