Defer .cbi/config loading until required #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading the configuration file when the module is imported can lead to a situation where an exception is thrown before logging is configured. Signed-off-by: John Pennycook <[email protected]>
laserkelvin
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loading the configuration file when the module is imported can lead to a situation where an exception is thrown before logging is configured.
Related issues
N/A
Proposed changes
configmodule is imported._compilersneeds to be populated the first time we create anArgumentParser.The configuration file probably should be loaded when
codebasinis imported, but it's currently not an easy fix due to some circular imports. The fix I'm proposing here is sufficient for 2.0.0, I think, but we should identify a better long-term fix as part of #172.