fix: improve comment propagation from lib4vex #4423
Conversation
We're getting a "comment" field from lib4vex and then trying to parse a "comments" one. this is an experiment to see if anything breaks if I "fix" it. Signed-off-by: Terri Oda <[email protected]>
|
So looks like this sort of works and does indeed break the tests: - 'comments': '',
+ 'comments': 'NotAffected: Detail field populated.',Not sure if "detail field populated" is the text that's in there or what off the top of my head, but it seems likely that this is heading in the correct direction at least? |
Signed-off-by: Terri Oda <[email protected]>
|
Looks like that is indeed the text shown in test files. I'm probably going to make some tweaks to that text to make debugging easier-- (right now one says "data" and another says "detail" and it's awkward. |
|
Nevermind, changing the comments (actually "details" or "action_statement" depending on the format) would require additional tweaks to the ouput tests that I don't think is the best use of my time today, so I'm going to go ahead and put this out there for code review without changing the text. Might open an issue getting someone else to tweak it later, though. |
terriko
changed the title
We're getting a "comment" field from lib4vex and then trying to parse a "comments" one. this is an experiment to see if any of our tests breaks if I "fix" it. (it is not, incidentally, fixing the full issue in 4417)