-
Notifications
You must be signed in to change notification settings - Fork 543
feat: basic tests and doc changes for no-scan mode #5138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: joydeep049 <[email protected]>
Signed-off-by: joydeep049 <[email protected]>
Signed-off-by: joydeep049 <[email protected]>
assert result.returncode == 0 | ||
|
||
|
||
def test_no_scan_output(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like this particular test is failing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, Initially I tried cve-bin-tool <directory> --no-scan
but that failed
Then I changed the entry point to cve_bin_tool/cli.py
but that seems to fail too
Surprising how --no-scan
shows up in python3 cve_bin_tool/cli.py --help
but not in the above
Signed-off-by: joydeep049 <[email protected]>
Signed-off-by: joydeep049 <[email protected]>
Signed-off-by: joydeep049 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: still failing:
=========================== short test summary info ===========================
FAILED test/test_no_scan.py::test_normal_scan - TypeError: argument of type 'NoneType' is not iterable
===== 1 failed, 2275 passed, 48 skipped, 8 warnings in 3420.69s (0:57:00) =====
There's also a pyupgrade linter fail so you should probably run that and see what got deprecated.
Looks like this might be the underlying issue that caused the failure:
Possibly a text encoding problem on Windows? |
Related Discussion : #5136
cc @terriko @anthonyharrison @mastersans