Bump logos and improve testing #181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JonatanWaern
commented
Dec 8, 2025
JonatanWaern
commented
- Improvements to lexer and testing
- Add parity test
JonatanWaern
force-pushed
the
bump-logos-0-16
branch
5 times, most recently
from
87f1556 to
a9e2272
Compare
JonatanWaern
force-pushed
the
bump-logos-0-16
branch
from
a9e2272 to
ecc728b
Compare
There was a problem hiding this comment.
Pull request overview
This PR bumps the logos library from version 0.15 to 0.16 and improves lexer/parser handling of unicode characters, particularly for UTF-16 encoding support. The changes ensure proper column position tracking for multi-byte unicode characters and fix issues with unended comment blocks.
Key Changes:
- Upgraded
logosdependency to version 0.16 - Fixed unicode character handling in multiline comments and C-blocks by switching from byte-based to character-based operations
- Updated parser to use UTF-16 encoding for column calculations to match LSP server defaults
- Added comprehensive tests for unicode handling and unended blocks
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| Cargo.toml | Bumped logos dependency from 0.15 to 0.16 |
| src/server/mod.rs | Added comment documenting UTF-16 default position encoding |
| src/analysis/parsing/parser.rs | Updated column calculations to use UTF-16 encoding and added unicode test |
| src/analysis/parsing/lexer.rs | Refactored multiline comment and C-block handlers to properly support unicode characters |
| CHANGELOG.md | Documented bug fixes for unicode and unended block handling |
| .github/workflows/rust.yml | Removed nightly cron schedule from main workflow |
| .github/workflows/nightly.yml | Created dedicated nightly workflow with parity testing |
| .github/workflows/binaries.yml | Added parity test support with configurable test path |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Bump Logos to .16 - Do not rely on Logos internals - Fix error in cblock handling - Fix errors in unicode and utf-16 handling - Add tests for above Signed-off-by: Jonatan Waern <[email protected]>
Signed-off-by: Jonatan Waern <[email protected]>
JonatanWaern
force-pushed
the
bump-logos-0-16
branch
from
ecc728b to
74dac56
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.