Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added const reference parameters #120

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added const reference parameters #120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Source/GmmLib/CachePolicy/GmmCachePolicy.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ MEMORY_OBJECT_CONTROL_STATE GMM_STDCALL GmmCachePolicyGetOriginalMemoryObject(vo
///
/// @return wanted memory type
/////////////////////////////////////////////////////////////////////////////////////
GMM_GFX_MEMORY_TYPE GmmGetWantedMemoryType(void *pLibContext, GMM_CACHE_POLICY_ELEMENT CachePolicy)
GMM_GFX_MEMORY_TYPE GmmGetWantedMemoryType(void *pLibContext, const GMM_CACHE_POLICY_ELEMENT &CachePolicy)
{
GMM_LIB_CONTEXT *pGmmLibContext = (GMM_LIB_CONTEXT *)pLibContext;
return pGmmLibContext->GetCachePolicyObj()->GetWantedMemoryType(CachePolicy);
Expand Down
2 changes: 1 addition & 1 deletion Source/GmmLib/CachePolicy/GmmCachePolicyCommon.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ GmmLib::GmmCachePolicyCommon::GmmCachePolicyCommon(GMM_CACHE_POLICY_ELEMENT *pCa
///
/// @return wanted memory type
/////////////////////////////////////////////////////////////////////////////////////
GMM_GFX_MEMORY_TYPE GmmLib::GmmCachePolicyCommon::GetWantedMemoryType(GMM_CACHE_POLICY_ELEMENT CachePolicy)
GMM_GFX_MEMORY_TYPE GmmLib::GmmCachePolicyCommon::GetWantedMemoryType(const GMM_CACHE_POLICY_ELEMENT &CachePolicy)
{
GMM_GFX_MEMORY_TYPE WantedMemoryType = GMM_GFX_UC_WITH_FENCE;
if(CachePolicy.WT)
Expand Down
2 changes: 1 addition & 1 deletion Source/GmmLib/CachePolicy/GmmGen10CachePolicy.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ GMM_STATUS GmmLib::GmmGen10CachePolicy::SetPATInitWA()
///
/// @return PAT Idx to use in the PTE
/////////////////////////////////////////////////////////////////////////////////////
uint32_t GmmLib::GmmGen10CachePolicy::BestMatchingPATIdx(GMM_CACHE_POLICY_ELEMENT CachePolicy)
uint32_t GmmLib::GmmGen10CachePolicy::BestMatchingPATIdx(const GMM_CACHE_POLICY_ELEMENT &CachePolicy)
{
uint32_t i;
uint32_t PATIdx = 0;
Expand Down
2 changes: 1 addition & 1 deletion Source/GmmLib/CachePolicy/GmmGen12CachePolicy.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,7 +408,7 @@ uint8_t GmmLib::GmmGen12CachePolicy::SelectNewPATIdx(GMM_GFX_MEMORY_TYPE WantedM
///
/// @return PAT Idx to use in the PTE
/////////////////////////////////////////////////////////////////////////////////////
uint32_t GmmLib::GmmGen12CachePolicy::BestMatchingPATIdx(GMM_CACHE_POLICY_ELEMENT CachePolicy)
uint32_t GmmLib::GmmGen12CachePolicy::BestMatchingPATIdx(const GMM_CACHE_POLICY_ELEMENT &CachePolicy)
{
uint32_t i;
uint32_t PATIdx = 0;
Expand Down
2 changes: 1 addition & 1 deletion Source/GmmLib/CachePolicy/GmmGen8CachePolicy.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,7 @@ GMM_STATUS GmmLib::GmmGen8CachePolicy::SetPATInitWA()
///
/// @return PAT Idx to use in the PTE
/////////////////////////////////////////////////////////////////////////////////////
uint32_t GmmLib::GmmGen8CachePolicy::BestMatchingPATIdx(GMM_CACHE_POLICY_ELEMENT CachePolicy)
uint32_t GmmLib::GmmGen8CachePolicy::BestMatchingPATIdx(const GMM_CACHE_POLICY_ELEMENT &CachePolicy)
{
uint32_t i;
uint32_t PATIdx = 0;
Expand Down
6 changes: 3 additions & 3 deletions Source/GmmLib/GlobalInfo/GmmInfo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ extern "C" GMM_STATUS GMM_STDCALL GmmCreateLibContext(const PLATFORM P
const GT_SYSTEM_INFO * pGtSysInfo,
ADAPTER_BDF sBdf)
#else
extern "C" GMM_STATUS GMM_STDCALL GmmCreateLibContext(const PLATFORM Platform,
extern "C" GMM_STATUS GMM_STDCALL GmmCreateLibContext(const PLATFORM &Platform,
const void * pSkuTable,
const void * pWaTable,
const void * pGtSysInfo,
Expand Down Expand Up @@ -224,7 +224,7 @@ GMM_STATUS GMM_STDCALL GmmLib::GmmMultiAdapterContext::AddContext(const PLATFORM
const char *DeviceRegistryPath,
uint32_t PhysicalAdapterIndex)
#else
GMM_STATUS GMM_STDCALL GmmLib::GmmMultiAdapterContext::AddContext(const PLATFORM Platform,
GMM_STATUS GMM_STDCALL GmmLib::GmmMultiAdapterContext::AddContext(const PLATFORM &Platform,
const void *_pSkuTable,
const void *_pWaTable,
const void *_pGtSysInfo,
Expand Down Expand Up @@ -1134,7 +1134,7 @@ GMM_CACHE_POLICY *GMM_STDCALL GmmLib::Context::CreateCachePolicyCommon()
return pGmmCachePolicy;
}

GMM_TEXTURE_CALC *GMM_STDCALL GmmLib::Context::CreateTextureCalc(PLATFORM Platform, bool Override)
GMM_TEXTURE_CALC *GMM_STDCALL GmmLib::Context::CreateTextureCalc(const PLATFORM &Platform, bool Override)
{
if(!Override)
{
Expand Down
2 changes: 1 addition & 1 deletion Source/GmmLib/Resource/GmmResourceInfo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1740,7 +1740,7 @@ uint32_t GMM_STDCALL GmmResIsMappedCompressible(GMM_RESOURCE_INFO *pGmmResource)
// Returns:
//
//-----------------------------------------------------------------------------
uint8_t __CanSupportStdTiling(GMM_TEXTURE_INFO Surf, GMM_LIB_CONTEXT *pGmmLibContext)
uint8_t __CanSupportStdTiling(const GMM_TEXTURE_INFO &Surf, GMM_LIB_CONTEXT *pGmmLibContext)
{
const __GMM_PLATFORM_RESOURCE *pPlatformResource = GMM_OVERRIDE_PLATFORM_INFO(&Surf, pGmmLibContext);

Expand Down
2 changes: 1 addition & 1 deletion Source/GmmLib/inc/External/Common/CachePolicy/GmmCachePolicyGen10.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ namespace GmmLib
{
protected:
/* Function prototypes */
uint32_t BestMatchingPATIdx(GMM_CACHE_POLICY_ELEMENT CachePolicy);
uint32_t BestMatchingPATIdx(const GMM_CACHE_POLICY_ELEMENT &CachePolicy);

public:
/* Constructors */
Expand Down
2 changes: 1 addition & 1 deletion Source/GmmLib/inc/External/Common/CachePolicy/GmmCachePolicyGen12.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ namespace GmmLib
/* Function prototypes */
GMM_STATUS InitCachePolicy();
uint8_t SelectNewPATIdx(GMM_GFX_MEMORY_TYPE WantedMT, GMM_GFX_MEMORY_TYPE MT1, GMM_GFX_MEMORY_TYPE MT2);
uint32_t BestMatchingPATIdx(GMM_CACHE_POLICY_ELEMENT CachePolicy);
uint32_t BestMatchingPATIdx(const GMM_CACHE_POLICY_ELEMENT &CachePolicy);
GMM_STATUS SetPATInitWA();
GMM_STATUS SetupPAT();
void SetUpMOCSTable();
Expand Down
2 changes: 1 addition & 1 deletion Source/GmmLib/inc/External/Common/CachePolicy/GmmCachePolicyGen8.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ namespace GmmLib
uint64_t *pPTEDwordValue);

/* Virtual function prototypes */
virtual uint32_t BestMatchingPATIdx(GMM_CACHE_POLICY_ELEMENT CachePolicy);
virtual uint32_t BestMatchingPATIdx(const GMM_CACHE_POLICY_ELEMENT &CachePolicy);

public:
/* Constructors */
Expand Down
2 changes: 1 addition & 1 deletion Source/GmmLib/inc/External/Common/GmmCachePolicy.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,7 +483,7 @@ typedef union GMM_PRIVATE_PAT_REC {

// Function Prototypes
GMM_STATUS GmmInitializeCachePolicy();
GMM_GFX_MEMORY_TYPE GmmGetWantedMemoryType(void *pLibContext, GMM_CACHE_POLICY_ELEMENT CachePolicy);
GMM_GFX_MEMORY_TYPE GmmGetWantedMemoryType(void *pLibContext, const GMM_CACHE_POLICY_ELEMENT &CachePolicy);

// Used for GMM ULT testing.
#ifdef __GMM_ULT
Expand Down
2 changes: 1 addition & 1 deletion Source/GmmLib/inc/External/Common/GmmCachePolicyCommon.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ namespace GmmLib
GmmCachePolicyCommon(GMM_CACHE_POLICY_ELEMENT *pCachePolicy, Context *pGmmLibContext);

/* Function prototypes */
GMM_GFX_MEMORY_TYPE GetWantedMemoryType(GMM_CACHE_POLICY_ELEMENT CachePolicy);
GMM_GFX_MEMORY_TYPE GetWantedMemoryType(const GMM_CACHE_POLICY_ELEMENT &CachePolicy);

#define DEFINE_CP_ELEMENT(Usage, llc, ellc, l3, wt, age, aom, lecc_scc, l3_scc, scf, sso, cos, hdcl1, l3evict, segov, glbgo, uclookup, l1cc, l2cc, l4cc, coherency, l3cc, l3clos, igPAT)\
do { \
Expand Down
2 changes: 1 addition & 1 deletion Source/GmmLib/inc/External/Common/GmmClientContext.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ extern "C" {
ADAPTER_BDF sBdf);
#else

GMM_STATUS GMM_STDCALL GmmCreateLibContext(const PLATFORM Platform,
GMM_STATUS GMM_STDCALL GmmCreateLibContext(const PLATFORM &Platform,
const void * pSkuTable,
const void * pWaTable,
const void * pGtSysInfo,
Expand Down
4 changes: 2 additions & 2 deletions Source/GmmLib/inc/External/Common/GmmInfo.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -573,7 +573,7 @@ namespace GmmLib
#endif // __GMM_KMD__

GMM_CACHE_POLICY* GMM_STDCALL CreateCachePolicyCommon();
GMM_TEXTURE_CALC* GMM_STDCALL CreateTextureCalc(PLATFORM Platform, bool Override);
GMM_TEXTURE_CALC* GMM_STDCALL CreateTextureCalc(const PLATFORM &Platform, bool Override);
GMM_PLATFORM_INFO_CLASS *GMM_STDCALL CreatePlatformInfo(PLATFORM Platform, bool Override);

private:
Expand Down Expand Up @@ -653,7 +653,7 @@ typedef struct _GMM_ADAPTER_INFO_
ADAPTER_BDF sBdf,
const char * DeviceRegistryPath);
#else
GMM_STATUS GMM_STDCALL AddContext(const PLATFORM Platform,
GMM_STATUS GMM_STDCALL AddContext(const PLATFORM &Platform,
const void * pSkuTable,
const void * pWaTable,
const void * pGtSysInfo,
Expand Down
2 changes: 1 addition & 1 deletion Source/GmmLib/inc/External/Common/GmmResourceInfo.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ typedef struct GMM_EXISTING_SYS_MEM_REC

uint8_t GMM_STDCALL GmmResValidateParams(GMM_RESOURCE_INFO *pResourceInfo);
void GMM_STDCALL GmmResGetRestrictions(GMM_RESOURCE_INFO* pResourceInfo, __GMM_BUFFER_TYPE* pRestrictions);
uint8_t __CanSupportStdTiling(GMM_TEXTURE_INFO Surface, GMM_LIB_CONTEXT *pGmmLibContext);
uint8_t __CanSupportStdTiling(const GMM_TEXTURE_INFO &Surface, GMM_LIB_CONTEXT *pGmmLibContext);

#ifdef __cplusplus
}
Expand Down