Skip to content

Change DPAS from OCL to SPV builtin #3732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

whitneywhtsang
Copy link
Contributor

SPEC: SPV_INTEL_subgroup_matrix_multiply_accumulate

Current Agama doesn't yet support the SPV extension, so test failures are expected.

Closes #3731

@chengjunlu
Copy link
Contributor

Does the SPV built-in support sub group size=32 for DPAS?

@whitneywhtsang
Copy link
Contributor Author

Does the SPV built-in support sub group size=32 for DPAS?

Last time I checked I saw Behavior is undefined if these functions are called on other devices or from kernels with a different subgroup size. Where can I find mention of that now @bashbaug?

@bashbaug
Copy link

Does the SPV built-in support sub group size=32 for DPAS?

Last time I checked I saw Behavior is undefined if these functions are called on other devices or from kernels with a different subgroup size. Where can I find mention of that now @bashbaug?

Hi, this is documented in an update to the OpenCL extension, which includes the changes to the SPIR-V environment describing the supported SPIR-V instructions and their operands. This hasn't been merged yet, but here is the PR:

KhronosGroup/OpenCL-Docs#1296

Here is the new section specifically:

https://github.com/KhronosGroup/OpenCL-Docs/blob/c9b757fb2cc0c3c52300b0289981154c680b7795/extensions/cl_intel_subgroup_matrix_multiply_accumulate.asciidoc#modifications-to-the-opencl-spir-v-environment-specification

In short, there is no change to the required sub-group sizes for dpas - DG2 still requires a sub-group size of 8, and PVC, BMG, etc. still require a sub-group size of 16.

@whitneywhtsang whitneywhtsang force-pushed the whitneywhtsang/spirv_dpas branch from ae9b5b4 to 08b07ae Compare April 17, 2025 18:29
Signed-off-by: Whitney Tsang <[email protected]>
@whitneywhtsang whitneywhtsang force-pushed the whitneywhtsang/spirv_dpas branch from 08b07ae to 296d8d0 Compare April 17, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change DPAS from OCL to SPV builtin
4 participants