[SYCL] Move GroupNonUniform SPIR-V built-in declarations to clang SPIRVBuiltins.td #17627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…RVBuiltins.td This PR changes scope parameter type from enum to int, aligning with SPV-IR. Mangling becomes more portable for targets that bypass SPIR-V. This PR constrains Id or Index type to be either uint32_t or uint64_t.
wenju-he
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
wenju-he
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
frasercrmck
approved these changes
Mar 25, 2025
clang/lib/Sema/SPIRVBuiltins.td
Outdated
| def TLFloat : TypeList<[Float, Double, Half]>; | ||
| // FIXME: handle properly char (signed or unsigned depending on host) | ||
| def TLSignedInts : TypeList<[Char, Short, Int, Long]>; | ||
| def TLUnsignedInts : TypeList<[UChar, UShort, UInt, ULong]>; | ||
| def TLUnsignedIntLong : TypeList<[UInt, ULong]>; |
There was a problem hiding this comment.
I wonder if this should be UIntULong? Just because UnsignedInt seems to be used above as the descriptive collection of unsigned integers, as opposed to the specific UInt type.
There was a problem hiding this comment.
TLUnsignedIntLong is removed in 4155e54
[UInt, ULong] is now not only used for Id type in GroupNonUniformBroadcast. ULong is no longer used for Delta/ClusterSize/Index parameters.
So I changed GroupNonUniformBroadcast to use [UInt, ULong] directly instead of adding TLUnsignedIntLong.
Fznamznon
approved these changes
Mar 25, 2025
jchlanda
approved these changes
Mar 25, 2025
…p ULong for Id type in GroupNonUniformBroadcast
|
kindly ping @llvm-reviewers-runtime @KseniyaTikhomirova for review |
|
@intel/llvm-gatekeepers please merge, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes scope parameter type from enum to int, aligning with SPV-IR. Mangling becomes more portable for targets that bypass SPIR-V.
This PR constrains Id type in GroupNonUniformBroadcast to be either uint32_t or uint64_t.
Following parameter types are constrained to be uint32_t:
The constraints should align with current built-in implementations and SPV-IR.