Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][E2E] Document undefined symbol tests for CUDA/HIP #17630

Merged
merged 2 commits into from
Apr 2, 2025
Merged

[SYCL][E2E] Document undefined symbol tests for CUDA/HIP #17630

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd14b4b
[SYCL][E2E] Document undefined symbol tests for CUDA/HIP
jchlanda Mar 25, 2025
533ddba
Typo fix and add cache-build-result.cpp, as it still has ze_debug uns…
jchlanda Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion sycl/test-e2e/KernelAndProgram/build-log.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
// for CUDA and HIP the failure happens at compile time, not during runtime
// UNSUPPORTED: target-nvidia || target-amd
// UNSUPPORTED-INTENDED: The test looks for an exception thrown during the
// compilation of the kernel, but for CUDA the failure is not thrown, but comes
// from ptxas that crashes clang. The JIT part is not relevant, because the
// flow is such that the AOT compilation still happens, it’s just that if we
// request JIT, it will do the thing again at the run time.
//
// TODO: rewrite this into a unit-test

// RUN: %{build} -DGPU -o %t_gpu.out
Expand Down
10 changes: 8 additions & 2 deletions sycl/test-e2e/KernelAndProgram/cache-build-result.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
// for CUDA and HIP the failure happens at compile time, not during runtime
// UNSUPPORTED: target-nvidia || target-amd || ze_debug
// UNSUPPORTED: target-nvidia || target-amd
// UNSUPPORTED-INTENDED: The test looks for an exception thrown during the
// compilation of the kernel, but for CUDA the failure is not thrown, but comes
// from ptxas that crashes clang. The JIT part is not relevant, because the
// flow is such that the AOT compilation still happens, it’s just that if we
// request JIT, it will do the thing again at the run time.
//
// UNSUPPORTED: ze_debug

// RUN: %{build} -DSYCL_DISABLE_FALLBACK_ASSERT=1 -o %t.out
// RUN: %{build} -DSYCL_DISABLE_FALLBACK_ASSERT=1 -DGPU -o %t_gpu.out
Expand Down
8 changes: 6 additions & 2 deletions sycl/test-e2e/KernelAndProgram/undefined-symbol.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
// for CUDA and HIP the failure happens at compile time, not during runtime
// UNSUPPORTED: target-nvidia || target-amd

// UNSUPPORTED-INTENDED: The test looks for an exception thrown during the
// compilation of the kernel, but for CUDA the failure is not thrown, but comes
// from ptxas that crashes clang. The JIT part is not relevant, because the
// flow is such that the AOT compilation still happens, it’s just that if we
// request JIT, it will do the thing again at the run time.
//
// RUN: %{build} -o %t.out
// RUN: %{run} %t.out
//
Expand Down
4 changes: 1 addition & 3 deletions sycl/test/e2e_test_requirements/no-unsupported-without-info.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
// tests to match the required format and in that case you should just update
// (i.e. reduce) the number and the list below.
//
// NUMBER-OF-UNSUPPORTED-WITHOUT-INFO: 282
// NUMBER-OF-UNSUPPORTED-WITHOUT-INFO: 280
//
// List of improperly UNSUPPORTED tests.
// Remove the CHECK once the test has been properly UNSUPPORTED.
Expand Down Expand Up @@ -208,7 +208,6 @@
// CHECK-NEXT: InvokeSimd/Feature/popcnt.cpp
// CHECK-NEXT: InvokeSimd/Regression/ImplicitSubgroup/call_vadd_1d_spill.cpp
// CHECK-NEXT: InvokeSimd/Regression/call_vadd_1d_spill.cpp
// CHECK-NEXT: KernelAndProgram/build-log.cpp
// CHECK-NEXT: KernelAndProgram/cache-build-result.cpp
// CHECK-NEXT: KernelAndProgram/free_function_apis.cpp
// CHECK-NEXT: KernelAndProgram/free_function_kernels.cpp
Expand All @@ -218,7 +217,6 @@
// CHECK-NEXT: KernelAndProgram/multiple-kernel-linking.cpp
// CHECK-NEXT: KernelAndProgram/spec_constants_after_link.cpp
// CHECK-NEXT: KernelAndProgram/spec_constants_after_link.cpp
// CHECK-NEXT: KernelAndProgram/undefined-symbol.cpp
// CHECK-NEXT: Matrix/SG32/element_wise_abc.cpp
// CHECK-NEXT: Matrix/SG32/element_wise_all_ops.cpp
// CHECK-NEXT: Matrix/SG32/element_wise_all_ops_half.cpp
Expand Down